Project

General

Profile

Bug #35110

Update APIv1 documentation for smarttest_disks

Added by Florian Lederer over 2 years ago. Updated about 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Waqar Ahmed
Category:
Middleware
Target version:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

When trying to configure a S.M.A.R.T. task and adding available disk from the dropdown menu following error message is displayed on saving the task:

Select a valid choice. {devicename}ada1 is not one of the available choices.

Tested on FreeNAS-11.2-MASTER-201806170436


Related issues

Copied to FreeNAS - Bug #35257: Fix disk identifier issue in new UIDone

Associated revisions

Revision 197e8ec5 (diff)
Added by Waqar Ahmed over 2 years ago

Documentation for smarttest api1.0 updated Ticket: #35110

Revision 600e74fa (diff)
Added by Waqar Ahmed over 2 years ago

Documentation for smarttest api1.0 updated Ticket: #35110

Revision a32028de (diff)
Added by Waqar Ahmed over 2 years ago

Documentation for smarttest api1.0 updated Ticket: #35110

Revision a2386b58 (diff)
Added by Waqar Ahmed over 2 years ago

Documentation for smarttest api1.0 updated Ticket: #35110

Revision f9c85c15 (diff)
Added by Waqar Ahmed about 2 years ago

Documentation for smarttest api1.0 updated Ticket: #35110

History

#2 Updated by Florian Lederer over 2 years ago

  • Description updated (diff)

#3 Updated by Florian Lederer over 2 years ago

Following message is shown in the /var/log/debug.log when trying to save the S.M.A.R.T. task

Jun 17 14:08:41 freenas uwsgi: [api.utils:12] Traceback (most recent call last):
Jun 17 14:08:41 freenas uwsgi: [api.utils:12]   File "./freenasUI/api/utils.py",line 251, in dispatch
Jun 17 14:08:41 freenas uwsgi: [api.utils:12]     request_type, request, *args,**kwargs
Jun 17 14:08:41 freenas uwsgi: [api.utils:12]   File "/usr/local/lib/python3.6/site-packages/tastypie/resources.py", line 482, in dispatch
Jun 17 14:08:41 freenas uwsgi: [api.utils:12]     response = method(request, **kwargs)
Jun 17 14:08:41 freenas uwsgi: [api.utils:12]   File "/usr/local/lib/python3.6/site-packages/tastypie/resources.py", line 1384, in post_list
Jun 17 14:08:41 freenas uwsgi: [api.utils:12]     updated_bundle = self.obj_create(bundle, **self.remove_api_resource_names(kwargs))
Jun 17 14:08:41 freenas uwsgi: [api.utils:12]   File "/usr/local/lib/python3.6/site-packages/tastypie/resources.py", line 2175, in obj_create
Jun 17 14:08:41 freenas uwsgi: [api.utils:12]     return self.save(bundle)
Jun 17 14:08:41 freenas uwsgi: [api.utils:12]   File "./freenasUI/api/utils.py", line 404, in save
Jun 17 14:08:41 freenas uwsgi: [api.utils:12]     response_class=http.HttpConflict,
Jun 17 14:08:41 freenas uwsgi: [api.utils:12] tastypie.exceptions.ImmediateHttpResponse

#4 Updated by Dru Lavigne over 2 years ago

  • Category changed from GUI (new) to Middleware
  • Assignee changed from Release Council to William Grzybowski

William: I assume that means that that device does not support SMART? Should the traceback error be fixed? Do you need a debug?

#5 Updated by William Grzybowski over 2 years ago

  • Assignee changed from William Grzybowski to Waqar Ahmed
  • Target version changed from Backlog to 11.2-RC2

Waqar, could you investigate this, please?

#6 Updated by Waqar Ahmed over 2 years ago

  • Status changed from Unscreened to In Progress

#7 Updated by Waqar Ahmed over 2 years ago

  • Copied to Bug #35257: Fix disk identifier issue in new UI added

#8 Updated by Waqar Ahmed over 2 years ago

  • Status changed from In Progress to Ready for Testing

The issue was with how the call was being made to API 1.0 in new UI. A related ticket has been made for this. For this ticket, the documentation for tasks in API 1.0's example has been updated to reflect the correct value which should be passed in the payload when creating smart tests.
PR - https://github.com/freenas/freenas/pull/1397

#9 Updated by Dru Lavigne over 2 years ago

  • Subject changed from adding disk for S.M.A.R.T. task fails to Update APIv1 documentation for smarttest_disks
  • Target version changed from 11.2-RC2 to 11.2-BETA1
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#10 Updated by Eric Turgeon about 2 years ago

POST was change in http://api.freenas.org/resources/tasks.html#smarttest with:

"smarttest_disks": ["{serial}VBcb6ca06c-657f8756"]

but GET and POST remain with

"smarttest_disks": [
                  "{devicename}vtbd3" 
          ]

I that how GET and PUT tasks smarttest documentation should be?

#11 Updated by William Grzybowski about 2 years ago

Eric Turgeon wrote:

POST was change in http://api.freenas.org/resources/tasks.html#smarttest with:

[...]

but GET and POST remain with
[...]

I that how GET and PUT tasks smarttest documentation should be?

That is just an example, {devicename}vtbd3 is also valid.

#12 Updated by Eric Turgeon about 2 years ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

William Grzybowski wrote:

Eric Turgeon wrote:

POST was change in http://api.freenas.org/resources/tasks.html#smarttest with:

[...]

but GET and POST remain with
[...]

I that how GET and PUT tasks smarttest documentation should be?

That is just an example, {devicename}vtbd3 is also valid.

Oh, Yeah, right.

#13 Updated by Dru Lavigne about 2 years ago

  • Status changed from Passed Testing to Done
  • Seen in changed from 11.2-RC2 to Master - FreeNAS Nightlies

Also available in: Atom PDF