Project

General

Profile

Bug #35272

Remove up/down arrows from number fields in new UI

Added by Warren Block over 2 years ago. Updated almost 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Dennis Mullen
Category:
GUI (new)
Target version:
Severity:
Low Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Several locations in the Angular GUI allow the user to enter a file or zvol size. These fields accept a plain number, and have up/down arrows to increase or decrease that number.

No units are shown, so the user has no way to easily tell whether the field is in K, M, or G. The up/down arrows are not very useful. Few people will scroll through a bunch of numbers instead of just typing one.

Replace these fields with a text input field that parses human-readable values. Let the user enter 20G or 20M or 2048K and calculate the required size from that. Show an error if the user does not enter a valid units letter.


Related issues

Related to FreeNAS - Bug #33933: VMs/DockerVM/Wizard: Add unit selection for RAW file sizeClosed
Has duplicate FreeNAS - Bug #38727: Remove up/down arrows from iSCSI Auth Group ID fieldClosed

History

#1 Updated by Erin Clark about 2 years ago

  • Assignee changed from Erin Clark to Dennis Mullen

#2 Updated by Dennis Mullen about 2 years ago

  • Status changed from Unscreened to Screened
  • Severity changed from New to Low Medium

#3 Updated by Warren Block about 2 years ago

The old UI had text input fields that accepted a number and a unit, like 20G. This might be the clearest way to enter and show values for the user.

Another method is separate value and units fields, but having the units dropdown sensitive to input on the value field. So if the user types 20G, the value field shows 20 and the units field shows G. If the user types 148M, the value field shows 148 and the units dropdown shows M. This would require Javascript input masking on the value field. The user could type any character, but only numerals would appear in the value field. Unit characters (G, M, K) would change the units field but not show in the value field. Other characters (punctuation and alpha) would not show or affect either field.

Reusable inputmask code would be valuable in many fields, particularly password fields where only a limited set of characters are accepted. At present, we allow the user to enter invalid characters, then complain about it with a validation message afterwards. Better for the user to catch those on input, being able to ignore them so they don't appear in the input field, or displaying a dialog when the user types a disallowed character.

There are some existing Javascript inputmask libraries that could be used for this.

#4 Updated by Dru Lavigne about 2 years ago

  • Target version changed from Backlog to 11.2-RC2

#6 Updated by Vaibhav Chauhan about 2 years ago

  • Related to Bug #33933: VMs/DockerVM/Wizard: Add unit selection for RAW file size added

#7 Updated by Dru Lavigne about 2 years ago

  • Target version changed from 11.2-RC2 to 11.2-BETA3

#8 Avatar?id=14398&size=24x24 Updated by Kris Moore about 2 years ago

  • Target version changed from 11.2-BETA3 to Backlog

#12 Updated by Dru Lavigne almost 2 years ago

  • Has duplicate Bug #38727: Remove up/down arrows from iSCSI Auth Group ID field added

#13 Updated by Dru Lavigne almost 2 years ago

  • Subject changed from File size fields are difficult to use and read to Remove arrows from number fields in new UI
  • Status changed from Screened to Ready for Testing
  • Target version changed from Backlog to 11.2-RC2
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#14 Updated by Dru Lavigne almost 2 years ago

  • Subject changed from Remove arrows from number fields in new UI to Remove up/down arrows from number fields in new UI

#16 Updated by Jeff Ervin almost 2 years ago

36834
36843

Test Passed FreeNAS-11.2-INTERNAL28

#18 Updated by Dru Lavigne almost 2 years ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF