Project

General

Profile

Bug #35371

Avatar?id=14398&size=50x50

Improve IPv4 validation for Plugins and Jails in new UI

Added by Kris Moore 10 months ago. Updated 9 months ago.

Status:
Done
Priority:
No priority
Assignee:
Lola Yang
Category:
GUI (new)
Target version:
11.2-BETA2
Seen in:
11.2-BETA1
Severity:
Med High
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

The plugin / jail creation when using a manual IPv4 / IPv6 address needs some improvement. The input box and tooltip both do not have any mention of the format expected, and unless the user happens to know its iocage in the backend, they may never guess the correct syntax.. For the record, its a syntax like the following: "igb0|192.168.0.50/24"

This needs to be fixed for 11.2. At BARE minimum we should have a tooltip that has an example. Ideally we have some regex which prevents submitting the form until the correct syntax is detected. Bonus points if we can make it "smarter" to detect different strings. I.E. if the user enters 192.168.0.50, the UI will toss on the /24 and default NIC for the user. If not, it could prompt for which network card to attach to.

Related issues

Has duplicate FreeNAS - Bug #37433: Inconsistent iocage syntax when entering IPv4 address during jail creationClosed
Has duplicate FreeNAS - Feature #27532: Provide validation for jail IP in new UIClosed

History

#1 Updated by Erin Clark 10 months ago

  • Assignee changed from Erin Clark to Lola Yang

#2 Updated by Lola Yang 10 months ago

  • Status changed from Unscreened to In Progress
  • Assignee changed from Lola Yang to Erin Clark

#3 Updated by Dru Lavigne 10 months ago

  • Subject changed from Improved Plugin/Jail IPv4 Input to Specify IPv4 format for Plugins and Jails in new UI
  • Assignee changed from Erin Clark to Lola Yang
  • Target version changed from 11.2-RC2 to 11.2-BETA2

#4 Updated by Dru Lavigne 10 months ago

  • Has duplicate Bug #37433: Inconsistent iocage syntax when entering IPv4 address during jail creation added

#5 Updated by Dru Lavigne 10 months ago

  • Subject changed from Specify IPv4 format for Plugins and Jails in new UI to Improve IPv4 validation for Plugins and Jails in new UI
  • Status changed from In Progress to Ready for Testing
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#6 Updated by Timothy Moore II 9 months ago

  • Status changed from Ready for Testing to Failed Testing

Testing with FreeNAS System updated to FreeNAS-11.2-MASTER-201807160837:

Go to Jails/Add (Wizard). In “Configure Networking”, experiment with different entries in the IPv4 Address field and IPv4 Netmask field. IPv4 Address field will accept 1.2.3.4, 1234567, 1234.123, or any combination of 7 digits regardless of how many decimal points are present.

#7 Updated by Lola Yang 9 months ago

  • Status changed from Failed Testing to In Progress

The ipv4 regex validation is not correct. i create a PR to fix it. https://github.com/freenas/webui/pull/1041

#8 Updated by Erin Clark 9 months ago

  • Status changed from In Progress to Ready for Testing

#9 Updated by Bonnie Follweiler 9 months ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

Test Passed in FreeNAS-11.2-MASTER-201807250900
It would only accept numbers like 1.2.3.4

#10 Updated by Dru Lavigne 9 months ago

  • Status changed from Passed Testing to Done

#11 Updated by Lola Yang 9 months ago

  • Has duplicate Feature #27532: Provide validation for jail IP in new UI added

Also available in: Atom PDF