Project

General

Profile

Bug #35410

Prevent user from editing a jail's properties in the new UI while the jail is running

Added by Michael Reynolds over 2 years ago. Updated about 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Lola Yang
Category:
GUI (new)
Target version:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

See https://redmine.ixsystems.com/issues/34771

The user is now presented with a scary Error dialog
See enableNetworkRunningJail-2018-06-20.png

This is much better than jails disappearing but the issue should be automatically handled or the warning dialog moved to more friendly red text that appears above the Save/Cancel buttons.

Handle automatically: Stop the jail, apply networking changes, start the jail

More friendly red warning text: The jail $JAILNAME is already started. Stop the jail then try again.
Something like that

Perhaps inform the user of the issue like the more friendly red text and give them a choice to "Stop Jail and apply changes" and Cancel

enableNetworkRunningJail-2018-06-20.png (58.9 KB) enableNetworkRunningJail-2018-06-20.png Michael Reynolds, 06/20/2018 10:01 AM
jailwarning.png (13.5 KB) jailwarning.png Rishabh Chauhan, 07/25/2018 09:19 AM
19072
22573

Related issues

Related to FreeNAS - Bug #56754: Provide read-only access to edit settings page when jail is runningDone

Associated revisions

Revision f500f3d0 (diff)
Added by Dru Lavigne about 2 years ago

Note that you can't edit a running jail. While here, clean up this section. Ticket: #35410

History

#1 Updated by Erin Clark over 2 years ago

  • Assignee changed from Erin Clark to Lola Yang

#2 Updated by Dru Lavigne about 2 years ago

  • Target version changed from Backlog to 11.2-RC2

#5 Updated by Dru Lavigne about 2 years ago

  • Target version changed from 11.2-RC2 to 11.2-BETA3

#7 Updated by Lola Yang about 2 years ago

  • Status changed from Unscreened to In Progress

Not able to edit dhcp, jail_zfs or template while jail is running.

https://github.com/freenas/webui/pull/1036

#8 Updated by Erin Clark about 2 years ago

  • Status changed from In Progress to Ready for Testing

#9 Updated by Dru Lavigne about 2 years ago

  • Subject changed from Improve the way the user is notified of Jail exceptions to Improve jail error message in new UI
  • Status changed from Ready for Testing to In Progress
  • Target version changed from 11.2-BETA3 to 11.2-BETA2

#11 Updated by Warren Block about 2 years ago

Please consult with docs on all user-visible text, including error messages. It is very important that we make these as clear as possible.

It's not clear what "jail_zfs" or "template" mean here. Why is the template code commented? Can users currently see anything regarding a template?

Existing message: "Not able to edit dhcp, jail_zfs or template while jails is running. Please stop jail first."

A guess at an alternate wording:
"Jail networking, jailed ZFS datasets (jail_zfs), or template usage cannot be changed while the jail is running. Please stop the jail before making these changes."

Note that we need to define what "template" means before we can be sure this is correct.

#12 Updated by Lola Yang about 2 years ago

Warren Block wrote:

Please consult with docs on all user-visible text, including error messages. It is very important that we make these as clear as possible.

It's not clear what "jail_zfs" or "template" mean here. Why is the template code commented? Can users currently see anything regarding a template?

Existing message: "Not able to edit dhcp, jail_zfs or template while jails is running. Please stop jail first."

A guess at an alternate wording:
"Jail networking, jailed ZFS datasets (jail_zfs), or template usage cannot be changed while the jail is running. Please stop the jail before making these changes."

Note that we need to define what "template" means before we can be sure this is correct.

Template is not available in UI, user can not see anything regarding a template.

#13 Updated by Erin Clark about 2 years ago

UI meeting: Hide edit button when jail is running

#14 Updated by Warren Block about 2 years ago

"Jails cannot be changed while running. Please stop the jail to make changes."

#15 Updated by Lola Yang about 2 years ago

Warren Block wrote:

"Jails cannot be changed while running. Please stop the jail to make changes."

Thanks Warren. https://github.com/freenas/webui/pull/1043

#16 Updated by Dru Lavigne about 2 years ago

  • Status changed from In Progress to Ready for Testing
  • Needs Merging changed from Yes to No

#17 Updated by Dru Lavigne about 2 years ago

  • Subject changed from Improve jail error message in new UI to Prevent user from editing a jail's properties in the new UI while the jail is running

#18 Updated by Rishabh Chauhan about 2 years ago

22573

FreeNAS-11.2-MASTER-201807250900
the Jail warning is precise and not scary anymore :P refescreenshot: : jail warning

#19 Updated by Dru Lavigne about 2 years ago

  • Status changed from Passed Testing to Done
  • Needs Doc changed from Yes to No

#20 Updated by Dru Lavigne almost 2 years ago

  • Related to Bug #56754: Provide read-only access to edit settings page when jail is running added

Also available in: Atom PDF