Project

General

Profile

Bug #35458

Add ability to check boxes in new UI by clicking on label in entity forms

Added by Warren Block over 2 years ago. Updated about 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Dennis Mullen
Category:
GUI (new)
Target version:
Severity:
Low Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Some checkboxes require clicking on the box.
Some allow clicking on the label text or the box.
Some show a black box around the checkbox when checked, some do not.

These should all look and work the same, preferably so the user can click on the text or the checkbox.


Related issues

Related to FreeNAS - Bug #37850: Cosmetic fixes to checkboxes in new UIDone

Associated revisions

Revision f7e9edcd (diff)
Added by Dennis Mullen about 2 years ago

Add ability to check boxes by clicking on label in entity forms, etc Ticket: #35458

Revision b470b682 (diff)
Added by Dennis Mullen about 2 years ago

Expand click target for ngx for entity tables, service cards, pool creation tables Ticket: #35458

History

#1 Updated by Erin Clark over 2 years ago

Can you give me some examples of these types of behaviors and where to find them?

#2 Updated by Erin Clark over 2 years ago

  • Status changed from Unscreened to Screened

#3 Updated by Warren Block over 2 years ago

Examples:

In the Delete zvol confirm dialog, the checkbox needs to be clicked twice the first time. Either box or text works.

In the Detach Pool dialog, both the Destroy Data and Confirm detach only allow clicks on the checkbox, not the text.

In the Network/Configuration screen, the "Enable netwait feature" checkbox only allows clicks on the checkbox, not the text.

In the System/Advanced screen, the "Enable Console Menu" checkbox only allows clicks on the checkbox, not the text.

In System/Update, the "Automatically check for new updates" checkbox allows clicks on checkbox or text.

#4 Updated by Erin Clark about 2 years ago

  • Status changed from Screened to Unscreened
  • Assignee changed from Erin Clark to Dennis Mullen

#5 Updated by Dennis Mullen about 2 years ago

  • Status changed from Unscreened to Screened
  • Severity changed from New to Low Medium

#6 Updated by Dennis Mullen about 2 years ago

PR 961

- Adds ability throughout the app to check a box by clicking its label
- Adds ability to data tables (jails, pool creation) to click anywhere on a row to select it
- Was unable to duplicate reported issue where two clicks are sometimes required
- Was unable to find any check boxes which retain the black border when checked

#7 Updated by Dru Lavigne about 2 years ago

  • Target version changed from Backlog to 11.2-BETA2

#8 Updated by Erin Clark about 2 years ago

  • Status changed from Screened to Ready for Testing

#9 Updated by Dru Lavigne about 2 years ago

  • Subject changed from Checkbox action is inconsistent to Add ability to check boxes in new UI by clicking on label in entity forms
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#10 Updated by Timothy Moore II about 2 years ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

Testing with FreeNAS system updated to FreeNAS-11.2-MASTER-201807120858:

Go to Storage/Pools. Delete existing zvol. Confirm checkbox is set with a single click on the box or text. Detach existing pool. “Destroy data” and “Confirm detach” checkboxes allow setting by clicking either the box or the text.

Go to Network/Global Configuration. “Enable netwait feature” checkbox can be set by clicking either the box or the text.

Go to System/Advanced. Each checkbox in the form can be set by clicking the field name or the checkbox.

Go to System/Update. “Automatically check for new updates” can be set by clicking the text or checkbox.

Confirmed with Dennis that the change to make table rows selectable by clicking anywhere within the row was reverted by another commit. This was additional functionality though, not the fix to the reported issue, so I'm not considering it a blocker.

Reviewed additional screens and wizards in the UI. Could not find any instances where the checkbox outline appeared after setting it or remained completely visible after setting.

Additional cosmetic behavior to be addressed in a separate ticket:

Cursor changes to pointer over checkbox but not text.
Clicking the checkbox plays a radiating color animation from the checkbox, clicking the text does not.
Exception to both behaviors: System/Update “Automatically check for new updates” field.
Also observed a few pixels from the checkbox seem to “bleed through” the checkmark at the corners.

#11 Updated by Timothy Moore II about 2 years ago

  • Related to Bug #37850: Cosmetic fixes to checkboxes in new UI added

#12 Updated by Dru Lavigne about 2 years ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF