Project

General

Profile

Bug #35491

Fix traceback for S3 validation errors in APIv1

Added by Waqar Ahmed 10 months ago. Updated 9 months ago.

Status:
Done
Priority:
No priority
Assignee:
Waqar Ahmed
Category:
Middleware
Target version:
Severity:
Low
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Validation errors raised from Middlewared leave a traceback in GUI when invalid values are provided. They should be displayed above their relevant fields as we do in GUI.


Related issues

Related to FreeNAS - Bug #38807: Add new error handling method for websocket errorsDone

Associated revisions

Revision 3d03a3d8 (diff)
Added by Waqar Ahmed 10 months ago

Traceback fixed for validation errors in S3
Ticket: #35491

History

#1 Updated by Waqar Ahmed 10 months ago

  • Status changed from Unscreened to In Progress

#2 Updated by Waqar Ahmed 10 months ago

  • Status changed from In Progress to Ready for Testing

#3 Updated by Dru Lavigne 10 months ago

  • Subject changed from S3 validation errors leave a traceback in GUI to Fix traceback for validation errors in S3
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#4 Updated by Timothy Moore II 9 months ago

  • Status changed from Ready for Testing to Failed Testing

Testing with FreeNAS Mini/System updated to FreeNAS-11.2-MASTER-201807160837:

Go to Services and configure S3. Enter invalid data for each field and click “Save”. A Popup appears describing the error. Repeated testing indicates this popup only seems to appear if the “Port” value is invalid (set to 0). Expected behavior is to validate the new settings, prevent saving when fields are misconfigured, and display errors above the fields that are incorrectly configured.

#5 Updated by Waqar Ahmed 9 months ago

Hello. So this ticket is only for legacy UI. It's purpose is to display the validation errors raised by Middlewared gracefully in the form instead of leaving a traceback. If you think that validation needs to be improved in some way, please create another ticket for that. Many thanks

#6 Updated by Dru Lavigne 9 months ago

  • Subject changed from Fix traceback for validation errors in S3 to Fix traceback for S3 validation errors in APIv1

#7 Updated by Timothy Moore II 9 months ago

  • Subject changed from Fix traceback for S3 validation errors in APIv1 to Fix traceback for validation errors in S3
  • Status changed from Failed Testing to Passed Testing
  • Needs QA changed from Yes to No

Thanks for the clarification!

Retesting with FreeNAS system updated to FreeNAS-11.2-MASTER-201807180859, legacy UI only:

Go to Services/S3 and click Configure (wrench). Enter invalid data for each field and click OK. Invalid fields are highlighted in red with explanations. No middleware traceback is shown, just the gui validation errors for each field.

#8 Updated by Timothy Moore II 9 months ago

  • Subject changed from Fix traceback for validation errors in S3 to changed from Fix traceback for S3 validation errors in APIv1

#9 Updated by Timothy Moore II 9 months ago

  • Subject changed from changed from Fix traceback for S3 validation errors in APIv1 to Fix traceback for S3 validation errors in APIv1

#10 Updated by Dru Lavigne 9 months ago

  • Status changed from Passed Testing to Done

#11 Updated by Timothy Moore II 9 months ago

  • Related to Bug #38807: Add new error handling method for websocket errors added

Also available in: Atom PDF