Fix traceback for S3 validation errors in APIv1
Validation errors raised from Middlewared leave a traceback in GUI when invalid values are provided. They should be displayed above their relevant fields as we do in GUI.
- Status changed from Ready for Testing to Failed Testing
Testing with FreeNAS Mini/System updated to FreeNAS-11.2-MASTER-201807160837:
Go to Services and configure S3. Enter invalid data for each field and click “Save”. A Popup appears describing the error. Repeated testing indicates this popup only seems to appear if the “Port” value is invalid (set to 0). Expected behavior is to validate the new settings, prevent saving when fields are misconfigured, and display errors above the fields that are incorrectly configured.
Hello. So this ticket is only for legacy UI. It's purpose is to display the validation errors raised by Middlewared gracefully in the form instead of leaving a traceback. If you think that validation needs to be improved in some way, please create another ticket for that. Many thanks
- Subject changed from Fix traceback for S3 validation errors in APIv1 to Fix traceback for validation errors in S3
- Status changed from Failed Testing to Passed Testing
- Needs QA changed from Yes to No
Thanks for the clarification!
Retesting with FreeNAS system updated to FreeNAS-11.2-MASTER-201807180859, legacy UI only:
Go to Services/S3 and click Configure (wrench). Enter invalid data for each field and click OK. Invalid fields are highlighted in red with explanations. No middleware traceback is shown, just the gui validation errors for each field.