Project

General

Profile

Bug #35653

Check GRUB presence via kenv instead of fstab

Added by Alexander Motin about 1 year ago. Updated about 1 year ago.

Status:
Done
Priority:
No priority
Assignee:
Alexander Motin
Category:
OS
Target version:
Seen in:
Severity:
High
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

It seems after #32412 FreeNAS 11.2 installs empty fstab, overwriting one that has GRUB line in it, that blocks `grep -q "grub" /conf/base/etc/fstab` in ix-bsdloader. As result, on WebUI update GRUB remains as loader, but probably won't function correctly, since we started to remove other required parts.

Associated revisions

Revision 696ab442 (diff)
Added by Alexander Motin about 1 year ago

Check GRUB presence via kenv instead of fstab.

It seems after #32412 we install empty fstab on update, overwriting
one with GRUB line in it, as result of what the GRUB removal script
doesn't activate.

Ticket: #35653

History

#1 Updated by Alexander Motin about 1 year ago

  • Status changed from Unscreened to In Progress

Unless there are better ideas, as possible solution I propose to replace `grep -q "grub" /conf/base/etc/fstab` check there, used to detect GRUB presence, with `kenv -q grub.platform >/dev/null`. Any objections?

#2 Updated by Dru Lavigne about 1 year ago

  • Target version changed from 11.2-BETA2 to 11.2-BETA1

#3 Updated by Alexander Motin about 1 year ago

  • Status changed from In Progress to Ready for Testing

#4 Updated by Dru Lavigne about 1 year ago

  • Subject changed from GRUB removal script is blocked to Check GRUB presence via kenv instead of fstab
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#6 Updated by Joe Maloney about 1 year ago

  • Status changed from Ready for Testing to Passed Testing

#7 Updated by Dru Lavigne about 1 year ago

  • Status changed from Passed Testing to Done
  • Needs QA changed from Yes to No

Also available in: Atom PDF