Project

General

Profile

Bug #35834

Bug #35626: Convert VMware Snapshot page to websocket in new UI

Fix traceback when editing VMware Snapshot task

Added by Vaibhav Chauhan about 1 year ago. Updated 12 months ago.

Status:
Done
Priority:
No priority
Assignee:
Waqar Ahmed
Category:
Middleware
Target version:
Severity:
Med High
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

assigning to william as I do not know who works on vmware middleware calls

middleware call: vmware.update

middleware payload:
[ 2, {hostname: "esxi02.tn.ixsystems.com", username: "root", password: "abcd1234", filesystem: "zpool/d0", datastore: "TDS1"}]

Error: Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 154, in call_method
result = await self.middleware.call_method(self, message)
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 110, in next
return self.gen.send(None)
File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 1013, in call_method
return await self._call(message['method'], serviceobj, methodobj, params, app=app, io_thread=False)
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 110, in next
return self.gen.send(None)
File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 953, in _call
return await methodobj(*args)
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 110, in next
return self.gen.send(None)
File "/usr/local/lib/python3.6/site-packages/middlewared/service.py", line 282, in update
f'{self._config.namespace}.update', self, self.do_update, [id, data]
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 110, in next
return self.gen.send(None)
File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 953, in _call
return await methodobj(*args)
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 110, in next
return self.gen.send(None)
File "/usr/local/lib/python3.6/site-packages/middlewared/schema.py", line 658, in nf
return await f(*args, **kwargs)
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 110, in next
return self.gen.send(None)
File "/usr/local/lib/python3.6/site-packages/middlewared/plugins/vmware.py", line 104, in do_update
await self.validate_data(new)
TypeError: validate_data() missing 1 required positional argument: 'schema_name'

Associated revisions

Revision 99e71454 (diff)
Added by Waqar Ahmed about 1 year ago

Bug fix when updating VMWare

Updating vmware snapshot instance failed due to a lacking argument. This commit fixes that.
Ticket: #35834

History

#1 Updated by William Grzybowski about 1 year ago

  • Assignee changed from William Grzybowski to Waqar Ahmed
  • Target version changed from Backlog to 11.2-BETA2

#2 Updated by Waqar Ahmed about 1 year ago

  • Status changed from Unscreened to In Progress

#3 Updated by Waqar Ahmed about 1 year ago

  • Severity changed from New to Med High

#4 Updated by Waqar Ahmed about 1 year ago

  • Status changed from In Progress to Ready for Testing

#5 Updated by Dru Lavigne about 1 year ago

  • Subject changed from editing vmware snapshot task using websocket calls is broken, to Fix traceback when editing VMware Snapshot task
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#6 Updated by Bonnie Follweiler 12 months ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

Test Passed in FreeNAS-11.2-MASTER-201807180859
(Build Date: Jul 18, 2018 12:5)

To edit you must enter the password or the Save button isn't active

#7 Updated by Dru Lavigne 12 months ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF