Project

General

Profile

Bug #35838

Don't rely on porcelain for cloning iocage remote repositories

Added by Martin Wilke over 2 years ago. Updated about 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Brandon Schneider
Category:
Middleware
Target version:
Severity:
Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

While upgrading to master the other day

iocage fetch -P --name btsync dhcp=on bpf=yes vnet=on
Plugin: btsync
  Official Plugin: True
  Using RELEASE: 11.1-RELEASE
  Post-install Artifact: https://github.com/freenas/iocage-plugin-btsync.git
  These pkgs will be installed:
    - net-p2p/rslsync
Fetching artifact...
Traceback (most recent call last):
  File "/usr/local/bin/iocage", line 10, in <module>
    sys.exit(cli())
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.6/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/iocage/cli/fetch.py", line 136, in cli
    ioc.IOCage(exit_on_error=True).fetch(**kwargs)
  File "/usr/local/lib/python3.6/site-packages/iocage/lib/iocage.py", line 917, in fetch
    ).fetch_plugin(name, props, 0, accept)
  File "/usr/local/lib/python3.6/site-packages/iocage/lib/ioc_plugin.py", line 125, in fetch_plugin
    self.__fetch_plugin_post_install__(conf, _conf, jaildir, jail_name)
  File "/usr/local/lib/python3.6/site-packages/iocage/lib/ioc_plugin.py", line 514, in __fetch_plugin_post_install__
    outstream=devnull, errstream=devnull)
  File "/usr/local/lib/python3.6/site-packages/dulwich/porcelain.py", line 324, in clone
    fetch_result = fetch(r, host_path, origin, message=reflog_message)
  File "/usr/local/lib/python3.6/site-packages/dulwich/porcelain.py", line 1077, in fetch
    fetch_result = client.fetch(path, r, progress=errstream.write)
  File "/usr/local/lib/python3.6/site-packages/dulwich/client.py", line 1026, in fetch
    with self._open_repo(path) as r:
  File "/usr/local/lib/python3.6/site-packages/dulwich/client.py", line 959, in _open_repo
    return closing(Repo(path))
  File "/usr/local/lib/python3.6/site-packages/dulwich/repo.py", line 773, in __init__
    "No git repository was found at %(path)s" % dict(path=root)
dulwich.errors.NotGitRepository: No git repository was found at /freenas/iocage-plugin-btsync.git

https://github.com/dulwich/dulwich/commit/bec27531b4e89fca928ea80aed1852c53a5c5478


Related issues

Related to FreeNAS - Bug #37443: Sync with iocage upstream 07/10/2018Done

History

#1 Updated by Brandon Schneider over 2 years ago

  • Category changed from Quality Engineering to Middleware
  • Status changed from Unscreened to Ready for Testing
  • Severity changed from New to Medium
  • Seen in changed from Unspecified to Master - FreeBSD-HEAD
  • Needs Merging changed from Yes to No

#2 Updated by William Grzybowski about 2 years ago

  • Status changed from Ready for Testing to Unscreened

Brandon,

Will this fix be in FreeNAS?

I see the commits in official iocage repo. If we want that in FreeNAS we need a PR in the fork.
Please set target version accordingly.

#3 Updated by Brandon Schneider about 2 years ago

  • Status changed from Unscreened to In Progress
  • Target version changed from Backlog to 11.2-BETA2

#4 Updated by Brandon Schneider about 2 years ago

  • Related to Bug #37443: Sync with iocage upstream 07/10/2018 added

#5 Updated by Brandon Schneider about 2 years ago

  • Status changed from In Progress to Ready for Testing

#6 Updated by Dru Lavigne about 2 years ago

  • Subject changed from iocage fails to clone remote repositories to Don't rely on porcelain for cloning iocage remote repositories
  • Needs Doc changed from Yes to No

#7 Updated by Timothy Moore II about 2 years ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

Testing with FreeNAS Mini manually updated to FreeNAS-11.2-MASTER-201807110935:

Went to Shell and entered `iocage fetch -P --name btsync dhcp=on bpf=yes vnet=on`
iocage fetches and installs FreeBSD. The plugin is installed and the admin portal is accessible. No errors or visible issues.

#8 Updated by Dru Lavigne about 2 years ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF