Project

General

Profile

Bug #35883

Be more strict with CRUDPlugin query filters

Added by Vladimir Vinogradenko over 1 year ago. Updated 8 months ago.

Status:
Done
Priority:
No priority
Assignee:
Vladimir Vinogradenko
Category:
Middleware
Target version:
Severity:
Low Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

https://github.com/freenas/freenas/pull/1439/commits/bacf78797f4d8ad4c2e3466915799dc15d82dc65 I think we should be more strict with CRUDPlugin query filters. It's not the first time I see bug like this


Risk
The risk is low since its an internal API and just making sure the arguments are correct

Acceptance Criteria
After this is done an error should be raised when calling query filters with wrong parameters:
e.g. midclt call user.query '["username", "=", "root"]'

Associated revisions

Revision 784a1cb6 (diff)
Added by Vladimir Vinogradenko over 1 year ago

fix(middleware): Be more strict with CRUDPlugin query filters Ticket: #35883

History

#1 Updated by William Grzybowski over 1 year ago

  • Description updated (diff)
  • Assignee changed from Release Council to Vladimir Vinogradenko
  • Severity changed from New to Low Medium
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#2 Updated by Vladimir Vinogradenko over 1 year ago

  • Status changed from Unscreened to Ready for Testing

#3 Updated by Dru Lavigne 11 months ago

  • Target version changed from 11.3 to 11.3-BETA1

#6 Updated by William Grzybowski 10 months ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

This has been tested multiple times by multiple devs in nightlies.

#7 Updated by Dru Lavigne 10 months ago

  • Status changed from Passed Testing to Done

#8 Updated by Dru Lavigne 8 months ago

  • Target version changed from 11.3-BETA1 to 11.3-ALPHA1

Also available in: Atom PDF