Bug #35933
Add style rules to render lighter text in dark themes
Description
I have the Dracula theme in use and some of the text on the VM wizard are black when they should be white.
Associated revisions
History
#1
Updated by Dru Lavigne almost 3 years ago
- Assignee changed from Release Council to Anonymous
#2 Updated by Anonymous almost 3 years ago
- Assignee changed from Anonymous to Dennis Mullen
#3
Updated by Dennis Mullen almost 3 years ago
- Status changed from Unscreened to In Progress
#4
Updated by Dru Lavigne almost 3 years ago
- Subject changed from Invalid themeing for VM wizard to Add style rules to render lighter text in dark themes
- Target version changed from Backlog to 11.2-BETA2
#5
Updated by Dennis Mullen almost 3 years ago
Now in combined PR 974
PR #941
In addition to the text that was too dark, this PR fixes several style issues across the various themes.
#6 Updated by Anonymous over 2 years ago
- Status changed from In Progress to Done
#7
Updated by Dru Lavigne over 2 years ago
- Status changed from Done to Ready for Testing
- Needs Doc changed from Yes to No
- Needs Merging changed from Yes to No
#8
Updated by Michael Reynolds over 2 years ago
- File ImportPools-2018-07-11.png ImportPools-2018-07-11.png added
- File VM-Wizard-2018-07-11.png VM-Wizard-2018-07-11.png added
- Status changed from Ready for Testing to Failed Testing
Marking this as Failed Testing
Switched to the Dracula theme
Wizard Steps still use black (are extremely dark) text on a dark background making it hard to read.
I'm not sure if the text is lighter than it originally was as it's hard to tell from the screenshots.
See ImportPools-2018-07-11.png and VM-Wizard-2018-07-11.png
#9
Updated by Dennis Mullen over 2 years ago
What you are looking at somehow doesn't include the modified branch. Attached is what I see in the nightlies - purple radio button, lighter text in the steps.
#10
Updated by Dru Lavigne over 2 years ago
- Status changed from Failed Testing to Ready for Testing
#11
Updated by Michael Reynolds over 2 years ago
- File DraculaTheme-2018-07-12.png DraculaTheme-2018-07-12.png added
- Status changed from Ready for Testing to Passed Testing
- Needs QA changed from Yes to No
Rechecked and this is now fixed for me as well in the 7-12 Nightly
#12
Updated by Dru Lavigne over 2 years ago
- Status changed from Passed Testing to Done