Project

General

Profile

Bug #35933

Avatar?id=55038&size=50x50

Add style rules to render lighter text in dark themes

Added by Zackary Welch over 2 years ago. Updated about 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Dennis Mullen
Category:
GUI (new)
Target version:
Seen in:
Severity:
Low
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

I have the Dracula theme in use and some of the text on the VM wizard are black when they should be white.

colorproblem.png (29.6 KB) colorproblem.png Zackary Welch, 06/26/2018 02:05 PM
ImportPools-2018-07-11.png (21.6 KB) ImportPools-2018-07-11.png Michael Reynolds, 07/11/2018 02:47 PM
VM-Wizard-2018-07-11.png (21.5 KB) VM-Wizard-2018-07-11.png Michael Reynolds, 07/11/2018 02:47 PM
drac.png (192 KB) drac.png Dennis Mullen, 07/12/2018 05:50 AM
DraculaTheme-2018-07-12.png (26.3 KB) DraculaTheme-2018-07-12.png Michael Reynolds, 07/12/2018 09:30 AM
19623
21134
21138
21170
21210

Associated revisions

Revision 3639da24 (diff)
Added by Dennis Mullen over 2 years ago

Add style rules to render lighter text in dark themes Ticket: #35933

Revision ec511926 (diff)
Added by Dennis Mullen over 2 years ago

Add theme-appropriate colors to tree nodes Ticket: #35933

Revision 3c3e43ee (diff)
Added by Dennis Mullen about 2 years ago

Css fix of checkboxes on dark themes, match arrow icons on vdev page to themes Ticket: #35933

Revision 38313373 (diff)
Added by Dennis Mullen about 2 years ago

Add style for pager buttons Ticket: #35933

History

#1 Updated by Dru Lavigne over 2 years ago

  • Assignee changed from Release Council to Erin Clark

#2 Updated by Erin Clark over 2 years ago

  • Assignee changed from Erin Clark to Dennis Mullen

#3 Updated by Dennis Mullen over 2 years ago

  • Status changed from Unscreened to In Progress

#4 Updated by Dru Lavigne about 2 years ago

  • Subject changed from Invalid themeing for VM wizard to Add style rules to render lighter text in dark themes
  • Target version changed from Backlog to 11.2-BETA2

#5 Updated by Dennis Mullen about 2 years ago

Now in combined PR 974

PR #941
In addition to the text that was too dark, this PR fixes several style issues across the various themes.

#6 Updated by Erin Clark about 2 years ago

  • Status changed from In Progress to Done

#7 Updated by Dru Lavigne about 2 years ago

  • Status changed from Done to Ready for Testing
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#8 Updated by Michael Reynolds about 2 years ago

21134
21138

Marking this as Failed Testing
Switched to the Dracula theme
Wizard Steps still use black (are extremely dark) text on a dark background making it hard to read.
I'm not sure if the text is lighter than it originally was as it's hard to tell from the screenshots.

See ImportPools-2018-07-11.png and VM-Wizard-2018-07-11.png

#9 Updated by Dennis Mullen about 2 years ago

21170

What you are looking at somehow doesn't include the modified branch. Attached is what I see in the nightlies - purple radio button, lighter text in the steps.

#10 Updated by Dru Lavigne about 2 years ago

  • Status changed from Failed Testing to Ready for Testing

#11 Updated by Michael Reynolds about 2 years ago

21210

Rechecked and this is now fixed for me as well in the 7-12 Nightly

#12 Updated by Dru Lavigne about 2 years ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF