Project

General

Profile

Bug #36568

Separate multiple SMART email addresses with a space

Added by Michael Reynolds over 1 year ago. Updated 8 months ago.

Status:
Done
Priority:
No priority
Assignee:
Vladimir Vinogradenko
Category:
Middleware
Target version:
Severity:
Low
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

This happens in both Legacy and webui

Legacy:
Go to Services:S.M.A.R.T. -> Email to report:

webui:
Go to Services:S.M.A.R.T. -> Configure -> Email

Enter a comma to separate email addresses (,)
The error returned is:
',': Should be valid E-Mail address

Enter a comma as part of an email address (a,)
The error returned is:
'a,': Should be valid E-Mail address

According to RFC 5321 and 5322, the local part of an Email address may
contain:

Letter
Digits
! # $ % & ' * + - / = ? ^ _ ` { | } ~ .

However, commas are technically allowed inside of quoted strings.

We do not allow quoted email addresses (as we shouldn't imho)

Comma separated email addresses are already disallowed. See https://redmine.ixsystems.com/issues/34951

We should error out on comma detection and advise commas are not allowed/valid characters.
The error should read something like:
Commas are not valid in an E-Mail address. Separate multiple E-Mail addresses with a space.

(Not sure if this should be handled in middleware or as a regex validation in the UI)

Email 4.png (20 KB) Email 4.png Jeff Ervin, 04/01/2019 01:04 PM
Email 5.png (21.6 KB) Email 5.png Jeff Ervin, 04/01/2019 01:04 PM
Email 3.png (23 KB) Email 3.png Jeff Ervin, 04/01/2019 01:04 PM
Email 2.png (20.8 KB) Email 2.png Jeff Ervin, 04/01/2019 01:04 PM
Email 1.png (24.1 KB) Email 1.png Jeff Ervin, 04/01/2019 01:05 PM
63259
63260
63268
63276
63284

Associated revisions

Revision 8a5d7c92 (diff)
Added by Vladimir Vinogradenko over 1 year ago

Commas are not valid in an E-Mail address. Separate multiple E-Mail addresses with a space. Ticket: #36568

History

#1 Updated by William Grzybowski over 1 year ago

  • Status changed from Unscreened to Screened
  • Severity changed from New to Low

#2 Updated by William Grzybowski over 1 year ago

  • Status changed from Screened to Unscreened
  • Assignee changed from William Grzybowski to Vladimir Vinogradenko
  • Target version changed from Backlog to 11.3
  • Needs Merging changed from Yes to No

#3 Updated by Vladimir Vinogradenko over 1 year ago

  • Status changed from Unscreened to In Progress

#4 Updated by Vladimir Vinogradenko over 1 year ago

  • Status changed from In Progress to Ready for Testing

#5 Updated by Dru Lavigne about 1 year ago

  • Subject changed from Services:S.M.A.R.T. -> Email: Improve error when comma found to Separate multiple SMART email addresses with a space

#6 Updated by Dru Lavigne 11 months ago

  • Target version changed from 11.3 to 11.3-BETA1

#8 Updated by Dru Lavigne 9 months ago

  • Needs Doc changed from Yes to No

#10 Updated by Jeff Ervin 9 months ago

63259
63260
63268
63276
63284

Test Passed FreeNAS-11.3-MASTER-201903281043

#11 Updated by Dru Lavigne 9 months ago

  • Status changed from Passed Testing to Done

#12 Updated by Dru Lavigne 8 months ago

  • Target version changed from 11.3-BETA1 to 11.3-ALPHA1

Also available in: Atom PDF