Project

General

Profile

Bug #37258

Standardize action button names in new UI

Added by Michael Dexter over 1 year ago. Updated over 1 year ago.

Status:
Done
Priority:
No priority
Assignee:
Dennis Mullen
Category:
GUI (new)
Target version:
Seen in:
Severity:
Low Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Many if not all confirmations show "Ok", which by several accounts should be "OK" or Okay, not Ok:

https://www.grammarly.com/blog/ok-okay/
https://english.stackexchange.com/questions/25617/difference-between-ok-and-okay

"Ok" is too informal.

Screenshot from 2018-07-19 14-25-02.png (151 KB) Screenshot from 2018-07-19 14-25-02.png Ok could often be replaced by action words Dennis Mullen, 07/19/2018 11:25 AM
Screenshot from 2018-08-16 10-21-19.png (3.76 KB) Screenshot from 2018-08-16 10-21-19.png A button toggle group Dennis Mullen, 08/16/2018 07:29 AM
22058
24534

History

#1 Updated by Dru Lavigne over 1 year ago

  • Assignee changed from Release Council to Erin Clark

#3 Updated by Dru Lavigne over 1 year ago

  • Target version changed from Backlog to 11.2-BETA2

#6 Updated by Erin Clark over 1 year ago

  • Assignee changed from Erin Clark to Dennis Mullen

#7 Updated by Dru Lavigne over 1 year ago

  • Target version changed from 11.2-BETA2 to Backlog

#9 Updated by Erin Clark over 1 year ago

UI Meeting: Buttons should be flat with semi-bold all caps text with default highlighted as per Material Design spec.

"Start scrub" for scrubs.

Theme might need adjusted if the default button color is unreadable, theme picker should calculate the color appropriately.

#10 Updated by Dennis Mullen over 1 year ago

  • Status changed from Unscreened to Screened

#11 Updated by Dennis Mullen over 1 year ago

  • Status changed from Screened to In Progress
  • Severity changed from New to Low Medium

#13 Updated by Dru Lavigne over 1 year ago

  • Target version changed from Backlog to 11.2-BETA3

#14 Updated by Dru Lavigne over 1 year ago

  • Subject changed from Ok -> OK or Okay to Standardize action button names in new UI
  • Status changed from In Progress to Ready for Testing
  • Needs Merging changed from Yes to No

#15 Updated by Timothy Moore II over 1 year ago

  • Status changed from Ready for Testing to Failed Testing

Testing with FreeNAS Mini updated to FreeNAS-11.2-MASTER-201808140859:

Go through each menu section, form, and attempt to view each dialog box that can appear in the ui.

Discovered instances where UI buttons don't conform to the standards:

  • Tasks/Cron Jobs: More Options/Run Now for an existing cron job. Dialog box uses "OK" button. Suggestions: CONFIRM, RUN NOW, START, GO, etc
  • Tasks/Rsync Tasks: More Options/Run Now for an existing rsync task. Dialog box uses "OK" button.
  • Tasks/Cloud Sync Tasks: More Options/Run Now for an existing cloud sync task. Dialog box uses "OK" button.
  • Storage/Pools/Add/Create Pool/Encryption dialog (appears when "Encryption" is set). Dialog box uses "OK" button. Suggestions: CONFIRM, I UNDERSTAND
  • Storage/Pools/Add/Create Pool/Create dialog (appears when "Create" is clicked). Dialog box uses "OK" button. Suggestions: CONTINUE, CREATE POOL
  • Storage/Pools/Pool Options > Delete zvol dialog. Dialog box uses "OK" button. Suggestions: DELETE ZVOL, CONFIRM, DELETE, CONTINUE
  • Storage/Pools/Pool Options > Delete dataset dialog. Dialog box uses "OK" button. Suggestions: DELETE DATASET, CONTINUE, DELETE
  • Plugins/Add: Raised buttons visible.
  • Jails/Edit: Raised buttons visible.
  • Jails/Mount Points/Delete (dialog): Dialog box uses "OK" button. Suggestions: DELETE MOUNT POINT, CONFIRM, CONTINUE
  • Jails/Add (Wizard and Advanced Jail Creation): Raised buttons visible.
  • VMs/Add (Wizard): Raised buttons visible.
  • VMs/Delete VM (dialog): Dialog box uses "OK" button. Suggestions: CONTINUE
  • VMs/Devices/Delete Device (dialog): Dialog box uses "OK" button. Suggestions: DELETE DEVICE, CONTINUE
  • Shell: "Reconnect" button is raised, "Restore default" button is raised.
  • UI Preferences: Buttons on form are raised.
  • UI Preferences/Create New Theme: Buttons on form are raised.

#16 Updated by Dru Lavigne over 1 year ago

  • Status changed from Failed Testing to In Progress

PR to address testing issues: https://github.com/freenas/webui/pull/1149

#17 Updated by Dennis Mullen over 1 year ago

24534

Commit 2d2d977 'flattens' all raised buttons except the example buttons on the Custom theme page. Also, it renders all buttons in Caps. A few pages (VM, Services) have a three-button 'toggle group' at the top, which kind of looks like the raised buttons, but it is a separate kind of component and I'm not sure if it should be rendered like regular buttons.

#18 Updated by Erin Clark over 1 year ago

  • Status changed from In Progress to Ready for Testing

#19 Updated by Timothy Moore II over 1 year ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

Testing with a FreeNAS system updated to FreeNAS-11.2-MASTER-201808210900:

Revisit each screen listed above as having nonstandard buttons and confirm all have been updated.

#21 Updated by Dru Lavigne over 1 year ago

  • Status changed from Passed Testing to Done
  • Needs Doc changed from Yes to No

Also available in: Atom PDF