Project

General

Profile

Bug #37263

Fix detection of the installer disk

Added by Michael Dexter about 2 years ago. Updated about 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Ryan Moeller
Category:
OS
Target version:
Seen in:
Severity:
Low Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

A FreeNAS installer booted from say, da0 will offer da0 as an install target. Confusing and hopefully will not permit installation unless on can installer over the booted installer. If so, document and promote, as that would be cool.

InstallTarget-2018-07-20.png (4.99 KB) InstallTarget-2018-07-20.png Michael Reynolds, 07/20/2018 12:26 PM
22215

Associated revisions

Revision 2dfbd2c0 (diff)
Added by Ryan Moeller about 2 years ago

Don't propose installing to the installer disk The installer disk label changed in the switch from GRUB to the BSD loader, breaking the detection of the installer disk in the install script. Ticket: #37263

History

#1 Updated by Dru Lavigne about 2 years ago

  • Assignee changed from Release Council to Alexander Motin

#3 Updated by Alexander Motin about 2 years ago

  • Assignee changed from Alexander Motin to Ryan Moeller

As I see we actually have code to handle that case. I guess something could change with the installer switch. Ryan, take a look on this please.

#4 Updated by Alexander Motin about 2 years ago

  • Severity changed from New to Low Medium

#5 Updated by Ryan Moeller about 2 years ago

  • Status changed from Unscreened to Screened

The installer disk label changed, breaking the detection code. Installing to the installer disk will destroy the partition table and then fail, corrupting the installer. I will either change the label back or change the detection code if changing the label is not so simple.

Risks
If not fixed, someone might corrupt their installer.

Acceptance Criteria
The booted installer disk should not appear in the disk selection dialog in the installer.

#6 Updated by Ryan Moeller about 2 years ago

  • Status changed from Screened to In Progress
  • Target version changed from Backlog to 11.2-BETA2

#7 Updated by Bug Clerk about 2 years ago

  • Status changed from In Progress to Ready for Testing

#8 Updated by Dru Lavigne about 2 years ago

  • Subject changed from Installer offers installer's boot device as an install target to Fix detection of the installer disk
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#9 Updated by Michael Reynolds about 2 years ago

22215

I don't get the install media as an install target.
This may need to be tested with a real cd and real hardware though

See InstallTarget-2018-07-20.png

#10 Updated by Ryan Moeller about 2 years ago

To clarify, you shouldn't get the install media as an install target.

The installer detects which device it is on so that it does not offer that device as an install target.

#11 Updated by Michael Reynolds about 2 years ago

  • Status changed from Ready for Testing to Passed Testing

Based on Ryan's comment, I'm passing this ticket

#12 Updated by Dru Lavigne about 2 years ago

  • Status changed from Passed Testing to Done
  • Needs QA changed from Yes to No

Also available in: Atom PDF