Project

General

Profile

Bug #37393

Bind children formControlName with parent in new UI

Added by Warren Block about 2 years ago. Updated about 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Vaibhav Chauhan
Category:
GUI (new)
Target version:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Choose System/Update, Manual Update. Select a pool to "temporarily store update file". Click Apply Update.

The filename is not required to be entered, and there is no error message that the file does not exist. The screen shows "Manual Update, starting job" and never comes back.

It needs to check for these conditions:
Error out with "Name of update file is required." if the user does not give a filename.
Error out with "File 'filename' cannot be read." if the filename given cannot be read.
Error out with "File 'filename' is not an update file." if the file is not an update file.

manual-update.png (32.7 KB) manual-update.png Warren Block, 07/10/2018 10:55 AM
20843

History

#1 Updated by Erin Clark about 2 years ago

  • Assignee changed from Erin Clark to Vaibhav Chauhan

#2 Updated by Dru Lavigne about 2 years ago

  • Target version changed from Backlog to 11.2-RC2

#3 Updated by Vaibhav Chauhan about 2 years ago

  • Status changed from Unscreened to In Progress
  • Target version changed from 11.2-RC2 to 11.2-BETA2

assigned to erin for review: https://github.com/freenas/webui/pull/987

#4 Updated by Dru Lavigne about 2 years ago

  • Subject changed from Manual Update does not check update file validity to Bind children formControlName with parent in new UI
  • Status changed from In Progress to Ready for Testing
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#5 Updated by Timothy Moore II about 2 years ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

Testing with FreeNAS System updated to FreeNAS-11.2-MASTER-201807160837:

Go to System/Update and click Manual Update. Chose temporary save location. “Apply Update” is unclickable. Click “Browse” to choose the locally saved update file. The only visible file is a manual-update.unsigned.tar file. Switch default view over to All Files. Choose one of the dummy files and click “Open”. File adds to FreeNAS UI. Click “Apply Update”. UI throws an error saying it is the wrong file type. Try several different dummy files, including a .tar file. The only file that was accepted was a Freenas manual update file.

#6 Updated by Dru Lavigne about 2 years ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF