Project

General

Profile

Feature #37642

Umbrella #25917: Move business logic from Django to middlewared and make websocket API feature complete

Convert Storage:Volume Remove Recovery Key to Middlewared

Added by William Grzybowski over 1 year ago. Updated 7 months ago.

Status:
Done
Priority:
Expected
Assignee:
William Grzybowski
Category:
Middleware
Target version:
Estimated time:
Severity:
Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
Yes
Support Suite Ticket:
n/a
Hardware Configuration:

Description

We need to change legacy UI to remove recovery key to a volume using middlewared calls (this is to make sure v1.0 API will continue working as expected)
We need to create associated middlewared API transferring logic from legacy UI code.

Risk
This is a medium risk task, we may introduce new bugs on remove recovery key.

Acceptance Criteria
When this is done we should be able to continue to revoming a recovery key a volume at full extent when using legacy UI.

key1.png (10.3 KB) key1.png Jeff Ervin, 03/22/2019 10:55 AM
key2.png (34.5 KB) key2.png Jeff Ervin, 03/22/2019 10:55 AM
62427
62435

Associated revisions

Revision 36038abe (diff)
Added by William Grzybowski over 1 year ago

feat(middlewared/pool): implement pool.recoverykey_rm While I'm here reuse validation gone among a feel encrypted pool methods. Ticket: #37642

Revision e3724d96 (diff)
Added by William Grzybowski over 1 year ago

feat(gui): use middleware to remove recovery key Ticket: #37642

Revision 7cfde9f1 (diff)
Added by William Grzybowski over 1 year ago

feat(middlewared/pool): implement pool.recoverykey_rm While I'm here reuse validation gone among a feel encrypted pool methods. Ticket: #37642

Revision f56e4609 (diff)
Added by William Grzybowski over 1 year ago

feat(gui): use middleware to remove recovery key Ticket: #37642

Revision 8d0686cc (diff)
Added by William Grzybowski over 1 year ago

fix(notifier): pass required arg to `pool.recoverykey_add` Ticket: #37642

Revision 2f93dca1 (diff)
Added by William Grzybowski over 1 year ago

fix(gui): wait for job to complete on download_job Ticket: #37642

Revision e38a55d4 (diff)
Added by William Grzybowski over 1 year ago

fix(notifier): pass required arg to `pool.recoverykey_add` Ticket: #37642

Revision 7f95baea (diff)
Added by William Grzybowski over 1 year ago

fix(gui): wait for job to complete on download_job Ticket: #37642

History

#1 Updated by William Grzybowski over 1 year ago

  • Status changed from Unscreened to Screened

#2 Updated by William Grzybowski over 1 year ago

  • Status changed from Screened to In Progress

#3 Updated by William Grzybowski over 1 year ago

  • Status changed from In Progress to Ready for Testing

#4 Updated by Dru Lavigne 9 months ago

  • Target version changed from 11.3 to 11.3-BETA1

#7 Updated by Jeff Ervin 7 months ago

62427
62435

Test Passed FreeNAS-11.3-MASTER-201903211102

Assuming I am understanding the acceptance criteria, for a locked volume, removed recovery key. Downloaded another key, locked and unlocked volume successfully.

#8 Updated by Dru Lavigne 7 months ago

  • Status changed from Passed Testing to Done

#9 Updated by Dru Lavigne 7 months ago

  • Target version changed from 11.3-BETA1 to 11.3-ALPHA1

Also available in: Atom PDF