Project

General

Profile

Feature #37714

Umbrella #25917: Move business logic from Django to middlewared and make websocket API feature complete

Convert Storage:Volume Lock/Unlock to Middlewared

Added by William Grzybowski over 1 year ago. Updated 7 months ago.

Status:
Done
Priority:
Expected
Assignee:
William Grzybowski
Category:
Middleware
Target version:
Estimated time:
Severity:
Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
Yes
Support Suite Ticket:
n/a
Hardware Configuration:

Description

We need to change legacy UI to lock and unlock of a volume using middlewared calls (this is to make sure v1.0 API will continue working as expected)
We need to create associated middlewared API transferring logic from legacy UI code.

Risk
This is a medium risk task, we may introduce new bugs on locking and unlocking a volume.

Acceptance Criteria
When this is done we should be able to continue to lock and unlock volume at full extent when using legacy UI.

Locked.png (27 KB) Locked.png Jeff Ervin, 03/22/2019 10:33 AM
Locked2.png (30.1 KB) Locked2.png Jeff Ervin, 03/22/2019 10:33 AM
62411
62419

Related issues

Related to FreeNAS - Bug #38395: Clear encryption key on standby node when pool is lockedReady for Testing

Associated revisions

Revision 2eeecd5b (diff)
Added by William Grzybowski over 1 year ago

feat(middlewared): always pass middleware as first arg to hooks Ticket: #37714

Revision 924bb667 (diff)
Added by William Grzybowski over 1 year ago

feat(middleware/zfs): implement zfs.pool.import_pool Ticket: #37714

Revision 7e80735a (diff)
Added by William Grzybowski over 1 year ago

feat(middlewared): implement pool.(un)?lock Ticket: #37714

Revision 980e71f5 (diff)
Added by William Grzybowski over 1 year ago

feat(gui): use middleware to lock/unlock volume Ticket: #37714

Revision 59efab6b (diff)
Added by William Grzybowski over 1 year ago

fix(middlewared/pool): handle mount failure on pool.unlock Ticket: #37714

Revision 995f73b8 (diff)
Added by William Grzybowski over 1 year ago

fix(middlewared/pool): detach geli if unlocking failed Ticket: #37714

Revision 6248807f (diff)
Added by William Grzybowski over 1 year ago

feat(middlewared): always pass middleware as first arg to hooks Ticket: #37714

Revision fac14d0d (diff)
Added by William Grzybowski over 1 year ago

feat(middleware/zfs): implement zfs.pool.import_pool Ticket: #37714

Revision 39a5f922 (diff)
Added by William Grzybowski over 1 year ago

feat(middlewared): implement pool.(un)?lock Ticket: #37714

Revision efcce4ff (diff)
Added by William Grzybowski over 1 year ago

feat(gui): use middleware to lock/unlock volume Ticket: #37714

Revision 9062374c (diff)
Added by William Grzybowski over 1 year ago

fix(middlewared/pool): handle mount failure on pool.unlock Ticket: #37714

Revision ab244136 (diff)
Added by William Grzybowski over 1 year ago

fix(middlewared/pool): detach geli if unlocking failed Ticket: #37714

History

#1 Updated by William Grzybowski over 1 year ago

  • Status changed from Unscreened to Screened

#2 Updated by William Grzybowski over 1 year ago

  • Related to Bug #38395: Clear encryption key on standby node when pool is locked added

#3 Updated by William Grzybowski over 1 year ago

  • Status changed from Screened to In Progress

#4 Updated by William Grzybowski over 1 year ago

  • Status changed from In Progress to Ready for Testing

#5 Updated by Dru Lavigne 10 months ago

  • Target version changed from 11.3 to 11.3-BETA1

#8 Updated by Jeff Ervin 8 months ago

62411
62419

Test Passed FreeNAS-11.3-MASTER-201903211102

Created a locked volume, created passphrase, downloaded Recovery Key. In Legacy UI, locked and unlocked volume successfully. In WebUI locked volume, switched to Legacy and successfully unlocked volume.

#9 Updated by Dru Lavigne 8 months ago

  • Status changed from Ready for Testing to Done

#10 Updated by Dru Lavigne 7 months ago

  • Target version changed from 11.3-BETA1 to 11.3-ALPHA1

Also available in: Atom PDF