Project

General

Profile

Bug #37850

Cosmetic fixes to checkboxes in new UI

Added by Timothy Moore II about 2 years ago. Updated about 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Dennis Mullen
Category:
GUI (new)
Target version:
11.2-BETA2
Seen in:
Master - FreeNAS Nightlies
Severity:
Low
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

While testing #35458, I observed a view cosmetic inconsistencies to checkboxes in the new UI:

- Cursor changes to pointer over checkbox but not text.
- Clicking the checkbox plays a radiating color animation from the checkbox, clicking the text does not.
- Exception to both behaviors: System/Update “Automatically check for new updates” field
- Observed a few pixels from the checkbox outline “bleeding through” the checkmark at the corners.

checkbox-outline.png (914 Bytes) checkbox-outline.png Timothy Moore II, 07/12/2018 08:36 AM
Screenshot from 2018-07-13 11-34-04.png (5.84 KB) Screenshot from 2018-07-13 11-34-04.png Our check box on the left, one from Angular's site on the right (but using a lighter frame) Dennis Mullen, 07/13/2018 01:17 PM
Screenshot from 2018-07-13 12-31-08.png (6.69 KB) Screenshot from 2018-07-13 12-31-08.png This is ours, blue fill, dark gray frame, practically invisible Dennis Mullen, 07/13/2018 01:22 PM
21182
21348
21368

Related issues

Related to FreeNAS - Bug #35458: Add ability to check boxes in new UI by clicking on label in entity formsDone

Associated revisions

Revision cd58c0c4 (diff)
Added by Dennis Mullen about 2 years ago

Fix checkbox on update dialog Ticket: #37850

History

#1 Updated by Timothy Moore II about 2 years ago

  • Related to Bug #35458: Add ability to check boxes in new UI by clicking on label in entity forms added

#2 Updated by Dru Lavigne about 2 years ago

  • Target version changed from Backlog to 11.2-RC2

#3 Updated by Erin Clark about 2 years ago

  • Assignee changed from Erin Clark to Dennis Mullen

#4 Updated by Dennis Mullen about 2 years ago

21348

PR 993

I think I have found and fixed the labels of all check boxes that have labels (the exception are the ones without labels on the entity table rows). All the rest show a pointer when hovered over and produce the full ripple effect when either the label or box is clicked.

As for the few dark pixels at the top corners, I believe this is a flaw of the material component itself. I see the same thing on the Angular material site (see pics). However it is practically invisible except when there is a great contrast between the color of the frame and of the fill. Since the check box and fill animation is a product we import via node modules, I don't think we can fix it.

#5 Updated by Dennis Mullen about 2 years ago

  • File Screenshot from 2018-07-13 12-31-08.png added

#6 Updated by Dennis Mullen about 2 years ago

  • File deleted (Screenshot from 2018-07-13 12-31-08.png)

#8 Updated by Dru Lavigne about 2 years ago

  • Status changed from Unscreened to Closed
  • Target version changed from 11.2-RC2 to N/A
  • Reason for Closing set to Not Applicable

#9 Updated by Dru Lavigne about 2 years ago

  • Status changed from Closed to In Progress
  • Target version changed from N/A to 11.2-BETA2
  • Reason for Closing deleted (Not Applicable)
  • Needs Doc changed from Yes to No

#11 Updated by Erin Clark about 2 years ago

  • Status changed from In Progress to Ready for Testing

#12 Updated by Dru Lavigne about 2 years ago

  • Needs Merging changed from Yes to No

#13 Updated by Bonnie Follweiler about 2 years ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

Test Passed in FreeNAS-11.2-MASTER-201807160837
(Build Date: Jul 16, 2018 11:40)

#14 Updated by Dru Lavigne about 2 years ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF