Project

General

Profile

Bug #38026

Add writeable certificates field when importing a certificate in new UI

Added by Waqar Ahmed about 2 years ago. Updated about 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Erin Clark
Category:
GUI (new)
Target version:
Seen in:
Severity:
Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

With the new UI (also applies to legacy UI) in 11.2-BETA1, I am now unable to complete CSR which are signed externally. In the UI for 11.1-U5 there is a form/box beneath the CSR form/box which is to be filled with the cert recieved by external CA, but this has gone missing with the new update.

Side note: Pressing enter when editing a CSR in legacy UI results in an exception as it (probably) wants the signed certificate which can't be input. Included in attachments in two parts.

There's a PR already complete for middlewared/legacy UI. Necessary changes should be made in the new UI to reflect the legacy UI. Thank you
PR - https://github.com/freenas/freenas/pull/1543


Related issues

Has duplicate FreeNAS - Bug #38903: Missing Certificate field for Certificate Signing RequestClosed
Copied from FreeNAS - Bug #37694: Allow users to paste the contents of certificates signed by an external CA Done

Associated revisions

Revision 33e0f785 (diff)
Added by Erin Clark about 2 years ago

Add writeable certificates field to CSR Ticket: #38026

Revision b99a38b0 (diff)
Added by Erin Clark about 2 years ago

Remove console.logs Ticket: #38026 #38807

History

#1 Updated by Waqar Ahmed about 2 years ago

  • Copied from Bug #37694: Allow users to paste the contents of certificates signed by an external CA added

#2 Updated by William Grzybowski about 2 years ago

  • Category changed from Middleware to GUI (new)

#3 Updated by Waqar Ahmed about 2 years ago

An example on how the call can be made to update the certificate field in a CSR

with cl() as c:
     d = c.call('certificate.update', 8, {'certificate': cert_string})

8 is the id of the csr and next is a dictionary which can have maximum two params, certificate and name. cert_string is a string which has been passed.

#4 Updated by Erin Clark about 2 years ago

Where should it do this? In the normal edit mode? How does old UI do this?

#5 Updated by Waqar Ahmed about 2 years ago

So when a user selects edit for a csr object in the UI, he should be displayed with 2 fields, one is the name field and the second is certificate field. He can edit both and click save. Once saved from middlewared's end, middlewared changes that objects type to a certificate from CSR and moving on that object should be dealt as a certificate instead of a CSR ( certs don't allow any field to be editable other then the name field ). Legacy UI handles it in the same manner described. The PR was merged and should be in nightlies where this behavior can be observed. Kindly let me know if there are any issues. Many thanks

#6 Updated by Timothy Moore II about 2 years ago

  • Has duplicate Bug #38903: Missing Certificate field for Certificate Signing Request added

#7 Updated by Erin Clark about 2 years ago

  • Status changed from Unscreened to In Progress

#8 Updated by Erin Clark about 2 years ago

  • Status changed from In Progress to Ready for Testing

#9 Updated by Dru Lavigne about 2 years ago

  • Subject changed from Cannot paste certificate from externally signed CSR to Add writeable certificates field to CSR in new UI
  • Private changed from Yes to No
  • Needs Merging changed from Yes to No

#10 Updated by Dru Lavigne about 2 years ago

  • File deleted (debug-freenas-test-20180711171603.txz)

#11 Updated by Dru Lavigne about 2 years ago

  • Subject changed from Add writeable certificates field to CSR in new UI to Add writeable certificates field when importing a certificate in new UI
  • Status changed from Ready for Testing to Done
  • Needs QA changed from Yes to No
  • Needs Doc changed from Yes to No

This passed testing: by selecting a Type of Import Certificate, the Certificate field accepts the pasted certificate.

Also available in: Atom PDF