Project

General

Profile

Bug #38615

Fix conflicting recordSizeMap keys in new UI

Added by Bonnie Follweiler 9 months ago. Updated 9 months ago.

Status:
Done
Priority:
No priority
Assignee:
Vaibhav Chauhan
Category:
GUI (new)
Target version:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Edit a dataset for a windows share that has a record size 1024K
I changed nothing and clicked the Save button and I got the following Traceback error:
Error saving dataset
[recordsize] Invalid choice: 1M

Error: Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 154, in call_method
result = await self.middleware.call_method(self, message)
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 110, in next
return self.gen.send(None)
File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 1013, in call_method
return await self._call(message['method'], serviceobj, methodobj, params, app=app, io_thread=False)
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 110, in next
return self.gen.send(None)
File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 953, in _call
return await methodobj(*args)
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 110, in next
return self.gen.send(None)
File "/usr/local/lib/python3.6/site-packages/middlewared/service.py", line 282, in update
f'{self._config.namespace}.update', self, self.do_update, [id, data]
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 110, in next
return self.gen.send(None)
File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 953, in _call
return await methodobj(*args)
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 110, in next
return self.gen.send(None)
File "/usr/local/lib/python3.6/site-packages/middlewared/schema.py", line 657, in nf
args, kwargs = clean_and_validate_args(args, kwargs)
File "/usr/local/lib/python3.6/site-packages/middlewared/schema.py", line 614, in clean_and_validate_args
value = attr.clean(args[args_index + i])
File "/usr/local/lib/python3.6/site-packages/middlewared/schema.py", line 383, in clean
data[key] = attr.clean(value)
File "/usr/local/lib/python3.6/site-packages/middlewared/schema.py", line 120, in clean
value = super(Str, self).clean(value)
File "/usr/local/lib/python3.6/site-packages/middlewared/schema.py", line 39, in clean
raise Error(self.name, f'Invalid choice: {value}')
middlewared.schema.Error: [recordsize] Invalid choice: 1M

History

#1 Updated by Bonnie Follweiler 9 months ago

FYI: It can be editied in the legacy UI

#2 Updated by Dru Lavigne 9 months ago

  • Target version changed from Backlog to 11.2-BETA3

#3 Updated by Erin Clark 9 months ago

  • Assignee changed from Erin Clark to Vaibhav Chauhan

There are two problems with this, one is that it is using the "value" which it should be using the rawsize mapped to a value and that it thinks it is inheriting the 1024k when it is not.

#4 Updated by Vaibhav Chauhan 9 months ago

#5 Updated by Dru Lavigne 9 months ago

  • Target version changed from 11.2-BETA3 to 11.2-BETA2

#6 Updated by Vaibhav Chauhan 9 months ago

  • Status changed from Unscreened to Screened

#7 Updated by Vaibhav Chauhan 9 months ago

  • Status changed from Screened to In Progress

#8 Updated by Erin Clark 9 months ago

  • Status changed from In Progress to Ready for Testing

#9 Updated by Dru Lavigne 9 months ago

  • Subject changed from In the new GUI, I can't edit a dataset for a windows share that has a record size 1024K I get a Traceback error to Fix conflicting recordSizeMap keys in new UI
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#10 Updated by Bonnie Follweiler 9 months ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

Test Passed in FreeNAS-11.2-MASTER-201807190857
(Build Date: Jul 19, 2018 12:3)

#11 Updated by Dru Lavigne 9 months ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF