Project

General

Profile

Bug #38807

Add new error handling method for websocket errors

Added by Timothy Moore II about 2 years ago. Updated about 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Erin Clark
Category:
GUI (new)
Target version:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Related to the Middleware fix in 35491, the Services/S3/Configure screen should be updated to display the validation errors and not the traceback popup message.

oldgui-services-s3-no-traceback.png (136 KB) oldgui-services-s3-no-traceback.png Timothy Moore II, 07/18/2018 12:52 PM
newgui-service-s3-traceback.png (91 KB) newgui-service-s3-traceback.png Timothy Moore II, 07/18/2018 12:52 PM
s3traceback.png (58.3 KB) s3traceback.png Rishabh Chauhan, 07/25/2018 09:37 AM
s3error.png (29 KB) s3error.png Rishabh Chauhan, 07/27/2018 11:38 AM
21875
21879
22578
23012

Related issues

Related to FreeNAS - Bug #35491: Fix traceback for S3 validation errors in APIv1Done
Related to FreeNAS - Feature #37483: Convert Smart test to entity-formDone
Related to FreeNAS - Bug #39937: Fix S3 service port validation in new UIDone

Associated revisions

Revision ed71d0ed (diff)
Added by Erin Clark about 2 years ago

Add new error handling method for websocket errors Ticket: #38807

Revision e35a0af1 (diff)
Added by Erin Clark about 2 years ago

Show error in entity errors if the field is hidden Ticket: #38807

Revision b99a38b0 (diff)
Added by Erin Clark about 2 years ago

Remove console.logs Ticket: #38026 #38807

Revision 964cfdf7 (diff)
Added by Erin Clark about 2 years ago

Add quick and dirty way to hide minutes from cron picker for SMART tasks Ticket: #38807 #37483

Revision f4577665 (diff)
Added by Erin Clark about 2 years ago

Use the improved websocket error handler for generic websocket calls Ticket: #38807

Revision 650f9211 (diff)
Added by Erin Clark about 2 years ago

Add validation to S3 port Ticket: #38807

History

#1 Updated by Timothy Moore II about 2 years ago

  • Related to Bug #35491: Fix traceback for S3 validation errors in APIv1 added

#3 Updated by Erin Clark about 2 years ago

I created a way to handle errors like described in this ticket in a similar page using EntityUtils, now we just need to go through and add it to all the pages like this one that use websockets.

#4 Updated by Dru Lavigne about 2 years ago

#5 Updated by Dru Lavigne about 2 years ago

  • Subject changed from Change validation error from traceback to direct display in the gui to Add new error handling method for websocket errors
  • Target version changed from 11.2-BETA3 to 11.2-BETA2
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#6 Updated by Dru Lavigne about 2 years ago

  • Status changed from Unscreened to Ready for Testing

#7 Updated by Rishabh Chauhan about 2 years ago

22578

FreeNAS-11.2-MASTER-201807250900
from what I understood from the conversation and ticket... Validation error should not give the traceback in the new UI, but I can still see it when I out in alphanumeric values for the ports... refer screenshot: s3traceback !
please confirm if it is a test pass or a fail...

#8 Updated by Dru Lavigne about 2 years ago

  • Status changed from Ready for Testing to Failed Testing

#9 Updated by Erin Clark about 2 years ago

  • Target version changed from 11.2-BETA2 to 11.2-BETA3

Sorry the PR in question only created the error handler and added it to one section, it did not pipe it throughout the entire UI in all the places it needed to be.

#10 Updated by Erin Clark about 2 years ago

  • Status changed from Failed Testing to In Progress

#11 Updated by Dru Lavigne about 2 years ago

  • Target version changed from 11.2-BETA3 to 11.2-BETA2

#12 Updated by Erin Clark about 2 years ago

https://github.com/freenas/webui/pull/1056 this PR adds the new error handling to generic WS calls, also for that specific port I added UI validation to prevent the user from typing in anything invalid

#13 Updated by Erin Clark about 2 years ago

  • Status changed from In Progress to Ready for Testing

#14 Updated by Rishabh Chauhan about 2 years ago

23012

I was able to enter a decimal in the ports... I am not sure if its a fail? I didn't get any error

#15 Updated by Dru Lavigne about 2 years ago

  • Related to Bug #39937: Fix S3 service port validation in new UI added

#16 Updated by Rishabh Chauhan about 2 years ago

  • Status changed from Ready for Testing to Failed Testing

#17 Updated by Dru Lavigne about 2 years ago

  • Status changed from Failed Testing to Done
  • Needs QA changed from Yes to No

The original issue in this ticket has been resolved. The validation for the port field will occur in the related ticket.

Also available in: Atom PDF