Project

General

Profile

Feature #39503

Fix bug in core.service unregister method for new UI

Added by Bonnie Follweiler about 2 years ago. Updated about 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Damian Szidiropulosz
Category:
GUI (new)
Target version:
Estimated time:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:

Description

On a mini running FreeNAS-11.2-MASTER-201807240859

Seen while testing https://redmine.ixsystems.com/issues/39103
I created a zvol, created a VM using that zvol, started up the vm, stopped the vm, deleted the zvol used by the VM, restarted the vm and got the error message.
The error spawns too many pop up windows that need to be cancelled to move on

History

#1 Updated by Bonnie Follweiler about 2 years ago

  • Subject changed from Trying to start a VM after deleting the zvol does give the correct error message in the new UI but it spawns over 5 windows that need to be closed to Trying to start a VM after deleting the zvol does give the correct error message in the new UI but it spawns to many popup windows

#2 Updated by Erin Clark about 2 years ago

  • Assignee changed from Erin Clark to Vaibhav Chauhan

#3 Updated by Dru Lavigne about 2 years ago

  • Target version changed from Backlog to 11.2-BETA3

#4 Updated by Vaibhav Chauhan about 2 years ago

  • Status changed from Unscreened to Screened

I have been narrow its reproduction case

1) create a functional VM try to run it once to make sure that VM starts to boot
2) stop the VM
3) edit the disk device to a non existing path, (add some extra character in the path)
4) click save
5) try to power on VM
6) you should see bunch of error dialogue overlayed on top of each other
7) if you happen to reload the browser this multiple error dialogue seems to get lost, to reproduce multiple error dialogue try to repeat steps from 3-5

what I have noticed that `VmStartFailed` is getting registered a few times, coincidentally number of times this service is registered == number of error dialoge.

one possible solution is to register `VmStartFailed` only once however this does require changes in core.service.ts file but there are regression that changes brings in.

#5 Updated by Vaibhav Chauhan about 2 years ago

  • Status changed from Screened to Unscreened
  • Assignee changed from Vaibhav Chauhan to Damian Szidiropulosz

Damian has a fix for it, nice job man.

#6 Updated by Damian Szidiropulosz about 2 years ago

  • Status changed from Unscreened to Done

There was a bug in core.service where components were not being unregistered from the dispatchTable. Fixed with PR 1060

#7 Updated by Vaibhav Chauhan about 2 years ago

  • Status changed from Done to Ready for Testing

right now we keep the status to ready for testing as our changes are not merged to master yet

#8 Updated by Erin Clark about 2 years ago

  • Status changed from Ready for Testing to In Progress

#10 Updated by Vaibhav Chauhan about 2 years ago

this is much needed UI bug fix this should be really considered to be put inside the BETA2 release.

#11 Updated by Erin Clark about 2 years ago

  • Status changed from In Progress to Ready for Testing

#13 Updated by Dru Lavigne about 2 years ago

  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#14 Updated by Dru Lavigne about 2 years ago

  • Target version changed from 11.2-BETA3 to 11.2-BETA2

#15 Updated by Dru Lavigne about 2 years ago

  • Subject changed from Trying to start a VM after deleting the zvol does give the correct error message in the new UI but it spawns to many popup windows to Fix bug in core.service unregister method for new UI

#16 Updated by Bonnie Follweiler about 2 years ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

I only got 1 error message
Test passed in FreeNAS-11.2-MASTER-201807270859
(Build Date: Jul 27, 2018 12:10)

#17 Updated by Dru Lavigne about 2 years ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF