Project

General

Profile

Bug #39682

Fix issues associated with a failed or interrupted plugin install in the new UI

Added by Warren Block over 2 years ago. Updated over 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Waqar Ahmed
Category:
Middleware
Target version:
11.2-RC1
Seen in:
11.2-BETA2
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Interrupting a plugin install during the download phase leaves a non-working jail installed. Attempting to install the plugin again fails because of the leftover jail.

Either the jail should not be created until downloads have been completed, or a failed plugin install should remove the things that were set up but will not work.

plugin.png (103 KB) plugin.png Warren Block, 07/26/2018 05:59 AM
Jail Issue 1.png (100 KB) Jail Issue 1.png Jeff Ervin, 08/30/2018 11:16 AM
Jail Issue 2.png (20.1 KB) Jail Issue 2.png Jeff Ervin, 08/30/2018 11:16 AM
Jail Issue 3.png (30.5 KB) Jail Issue 3.png Jeff Ervin, 08/30/2018 11:17 AM
Jail Issue 4.png (74.2 KB) Jail Issue 4.png Jeff Ervin, 08/30/2018 11:17 AM
Jail Issue 5.png (49.9 KB) Jail Issue 5.png Jeff Ervin, 08/30/2018 11:17 AM
Screenshot-2018-10-1 FreeNAS - 10 231 5 190(5).png (35.5 KB) Screenshot-2018-10-1 FreeNAS - 10 231 5 190(5).png Jeff Ervin, 10/01/2018 09:51 AM
Screenshot-2018-10-1 FreeNAS - 10 231 5 190(4).png (26.1 KB) Screenshot-2018-10-1 FreeNAS - 10 231 5 190(4).png Jeff Ervin, 10/01/2018 09:51 AM
Screenshot-2018-10-1 FreeNAS - 10 231 5 190(6).png (37.9 KB) Screenshot-2018-10-1 FreeNAS - 10 231 5 190(6).png Jeff Ervin, 10/01/2018 09:51 AM
22727
27542
27553
27564
27575
27586
32708
32716
32719

Related issues

Has duplicate FreeNAS - Bug #41324: If Jail exists with preferred jailname of a plugin, plugin script DESTROYS jail.Closed
Has duplicate FreeNAS - Bug #40848: Can install multiple plugins with same static IPClosed
Blocked by FreeNAS - Feature #41694: Improve validation for jail creationDone

History

#1 Updated by Dru Lavigne over 2 years ago

  • Target version changed from Backlog to 11.2-BETA3

#2 Updated by Anonymous over 2 years ago

  • Assignee changed from Anonymous to Lola Yang

#3 Updated by Lola Yang over 2 years ago

Hi Warren, if plugin installed failed, an error dialog will pop up and the plugin will be automatically delete. Have you see any error dialog pop up when you install a plugin?

#4 Updated by Dru Lavigne over 2 years ago

  • Status changed from Unscreened to Blocked
  • Reason for Blocked set to Need additional information from Author

#5 Updated by Timothy Moore II over 2 years ago

Attempting to reproduce this by starting a plugin install then pulling the system's ethernet cable and letting the system time out. Several different attempts result the same way: a entry appears in "Plugins/Installed" with a plugin jail either in a up or down state. I'm not seeing any error messages either.

Further investigation indicates installing a plugin immediately creates an iocage jail with the latest RELEASE of FreeBSD. If that RELEASE has been previously fetched then a jail will be created regardless of the system's ability to download the actual plugin. Searching within one of these jails doesn't appear to actually have the plugin that was supposed to be fetched; it is just a simple FreeBSD jail with none of the actual plugin bits installed.

#6 Updated by Dru Lavigne over 2 years ago

  • Status changed from Blocked to Unscreened

#7 Updated by Dru Lavigne over 2 years ago

  • Reason for Blocked deleted (Need additional information from Author)

#8 Updated by Lola Yang over 2 years ago

  • Blocked by Feature #41694: Improve validation for jail creation added

#9 Updated by Anonymous over 2 years ago

  • Related to Bug #41324: If Jail exists with preferred jailname of a plugin, plugin script DESTROYS jail. added

#10 Updated by Lola Yang over 2 years ago

  • Status changed from Unscreened to Blocked

#11 Updated by Dru Lavigne over 2 years ago

  • Status changed from Blocked to Not Started

#12 Updated by Lola Yang over 2 years ago

  • Status changed from Not Started to In Progress

#13 Updated by Dru Lavigne over 2 years ago

  • Subject changed from Interrupting a plugin install does not clean up to Fix issues associated with a failed or interruped plugin install in the new UI
  • Needs Doc changed from Yes to No

#14 Updated by Dru Lavigne over 2 years ago

  • Subject changed from Fix issues associated with a failed or interruped plugin install in the new UI to Fix issues associated with a failed or interrupted plugin install in the new UI

#15 Updated by Dru Lavigne over 2 years ago

  • Related to deleted (Bug #41324: If Jail exists with preferred jailname of a plugin, plugin script DESTROYS jail.)

#16 Updated by Dru Lavigne over 2 years ago

  • Has duplicate Bug #41324: If Jail exists with preferred jailname of a plugin, plugin script DESTROYS jail. added

#17 Updated by Dru Lavigne over 2 years ago

  • Has duplicate Bug #40848: Can install multiple plugins with same static IP added

#18 Updated by Dru Lavigne over 2 years ago

  • Status changed from In Progress to Ready for Testing
  • Needs Merging changed from Yes to No

#20 Updated by Jeff Ervin over 2 years ago

27542
27553
27564
27575
27586

Test Fails FreeNAS-11.2-MASTER-201808220903

installed Jail2, while installing, powered down. After reboot, attempted to install another jail2. Jail2 was created but did not show up under the jails area (no jails that I had created before this test case showed here), but they did show up under storage/pools. Rebooted again, and then all the jails showed where they were supposed to.

Installed jail3, while installing, powered down. After reboot, attempted to install jail3 and received the error message in screenshot Jail Issue 5.

#21 Updated by Anonymous over 2 years ago

  • Assignee changed from Lola Yang to William Grzybowski

#22 Updated by Anonymous over 2 years ago Private

Lola's fix only removes the plugin deletion from the UI so that the middleware can handle it, I am passing this to William so his team can investigate this issue further.

#23 Updated by William Grzybowski over 2 years ago

  • Category changed from GUI (new) to Middleware
  • Assignee changed from William Grzybowski to Waqar Ahmed

Waqar can you investigate this, please?

#24 Updated by William Grzybowski over 2 years ago

  • Target version changed from 11.2-BETA3 to 11.2-RC1

Shutting down is a very rare edge case. We will see if we can handle that for RC1. Not critical for BETA3.

#25 Updated by Jeff Ervin over 2 years ago

32708
32716
32719

Test Passed FreeNAS-11.2-MASTER-201810010839

I've installed 3 plugins, interrupted each, mid-install via reboot, gone back into the jails (after refreshing the browser each time), they're not installed. Installed each one that was interrupted afterwards without issue...

#26 Updated by Dru Lavigne over 2 years ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF