Project

General

Profile

Bug #39842

Hide actions that cannot be used when pool is locked and display unlock button when pool is locked

Added by Timothy Moore II about 2 years ago. Updated about 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Erin Clark
Category:
GUI (new)
Target version:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Seen on a FreeNAS system updated to FreeNAS-11.2-MASTER-201807261941.

I went to Storage/Pools and expanded the entry for locked pool "lock-test". After clicking the "Gear" icon (Pool Operations), there are options to Detach, Extend, Scrub Pool, and Status. Clicking "Scrub Pool" closes the "Gear" icon menu and does nothing else. I'm guessing this does nothing because the pool is locked. If so, could this option be made either invisible or greyed out so it isn't even presented as a valid option for a locked pool? "Status" has the same problem, clicking it goes to a screen that presents no substantive information, as the disk is locked. This option should probably be greyed out as well.

The "Lock" icon (Encryption Operations) for a locked pool has a single option when clicked: "Un-Lock". Clicking it opens a popup window to unlock the pool. At minimum, this entry should be reworded: "Unlock Pool". A better solution is to just open the "Unlock Pool" popup window when the "Lock" icon is clicked. This would improve the user experience.

General design suggestion: When a UI icon has a single option, clicking the icon should immediately go to that option. The icon tooltip should show that option. This removes unneeded menus and clicks from the UI.

locked-pool-options.png (67.9 KB) locked-pool-options.png Timothy Moore II, 07/27/2018 06:26 AM
locked-pool-Un-Lock-option.png (69.4 KB) locked-pool-Un-Lock-option.png Timothy Moore II, 07/27/2018 06:26 AM
locked_pool.png (131 KB) locked_pool.png Aaron St. John, 08/27/2018 10:00 AM
22882
22887
25948

Associated revisions

Revision 500b295e (diff)
Added by Erin Clark about 2 years ago

Hide actions that cannot be used when pool is locked and convert lock menu to unlock button when pool is locked Ticket: #39842

History

#1 Updated by Dru Lavigne about 2 years ago

  • Target version changed from Backlog to 11.2-BETA3

#3 Updated by Erin Clark about 2 years ago

  • Assignee changed from Erin Clark to Dennis Mullen

#4 Updated by Erin Clark about 2 years ago

  • Assignee changed from Dennis Mullen to Erin Clark

#5 Updated by Erin Clark about 2 years ago

This page still needs to be redesigned but this PR at least tries to tackle the fixes described in this ticket:

https://github.com/freenas/webui/pull/1161

#6 Updated by Erin Clark about 2 years ago

  • Status changed from Unscreened to In Progress

#7 Updated by Dru Lavigne about 2 years ago

  • Subject changed from Storage/Pools: Adjust visibility of options for a locked pool. to Hide actions that cannot be used when pool is locked and display unlock button when pool is locked

#8 Updated by Erin Clark about 2 years ago

  • Status changed from In Progress to Ready for Testing

#9 Updated by Dru Lavigne about 2 years ago

  • Needs Merging changed from Yes to No

#10 Updated by Aaron St. John about 2 years ago

25948

Tested on FreeNAS-11.2-MASTER-201808270839

See screenshot.

I'm waiting to change docs. After speaking with Tim, he said that he made some changes to the docs about locking pools. I will wait until his changes are merged before I make substantive changes to them also.

#11 Updated by Aaron St. John about 2 years ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

#12 Updated by Aaron St. John about 2 years ago

  • Needs Doc changed from Yes to No

After review the work that was merged in from Tim's PR, it appeared everything was good to go in docs.

(docs) Angulargui branch (Tim's) PR: https://github.com/freenas/freenas-docs/pull/318

and https://github.com/freenas/freenas-docs/pull/331

#13 Updated by Dru Lavigne about 2 years ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF