Project

General

Profile

Bug #39962

Add validation for FTP fields in new UI

Added by Michael Reynolds about 2 years ago. Updated about 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Erin Clark
Category:
GUI (new)
Target version:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Services:FTP -> Configure

The Clients field is to specify the number of client connections allowed at 1 time

This field currently allows 0 and letters

We should disallow 0 and letters from being entered.

FTP Validation Fail 1.png (190 KB) FTP Validation Fail 1.png Jeff Ervin, 08/27/2018 07:30 AM
25857

Associated revisions

Revision c99695cb (diff)
Added by Erin Clark about 2 years ago

Add validation and linting fixes for FTP service Ticket: #39962

Revision 05d5b1f5 (diff)
Added by Erin Clark about 2 years ago

Add ability to deselect certificate to FTP service Ticket: #39962

Revision 8529d91b (diff)
Added by Erin Clark about 2 years ago

Create range validator to simplify validating positive integer ranges Ticket: #39962

Revision b6a6320b (diff)
Added by Erin Clark about 2 years ago

Use range validator on ftp service to validate the integer fields Ticket: #39962

History

#1 Updated by Dru Lavigne about 2 years ago

  • Target version changed from Backlog to 11.2-BETA3

#3 Updated by Erin Clark about 2 years ago

  • Status changed from Unscreened to In Progress

https://github.com/freenas/webui/pull/1071 this PR adds validation to pretty much all of the numeric fields in FTP that need them

#4 Updated by Dru Lavigne about 2 years ago

  • Subject changed from Add validation for number of FTP Clients field to Add validation for FTP fields in new UI
  • Status changed from In Progress to Ready for Testing
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#5 Updated by Jeff Ervin about 2 years ago

25857

Test Fails FreeNAS-11.2-MASTER-201808220903

#6 Updated by Erin Clark about 2 years ago

  • Status changed from Failed Testing to Ready for Testing

#7 Updated by Erin Clark about 2 years ago

https://github.com/freenas/webui/pull/1200 this PR was merged to fix the validation

#8 Updated by Jeff Ervin about 2 years ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

Test Passes FreeNAS-11.2-MASTER-201808220903

#9 Updated by Dru Lavigne about 2 years ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF