Project

General

Profile

Bug #40456

Perform VM memory check at the beginning of the create VM wizard in the new UI

Added by Chris Burge over 1 year ago. Updated over 1 year ago.

Status:
Done
Priority:
No priority
Assignee:
Vaibhav Chauhan
Category:
GUI (new)
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Problem: The VM wizard does not check memory provision and allows creation of VM. Only when starting VM does the memory check take place. User is then forced to delete and re-create vm from scratch.

Steps to re-create: See attached screen caps.

vmtest2_2.jpeg (28.4 KB) vmtest2_2.jpeg Chris Burge, 08/02/2018 01:42 AM
vmtest2_3.jpeg (59.1 KB) vmtest2_3.jpeg Chris Burge, 08/02/2018 01:42 AM
VM_memory_check.png (53.7 KB) VM_memory_check.png Aaron St. John, 08/16/2018 10:14 AM
VM_memory_usage_error.png (282 KB) VM_memory_usage_error.png Aaron St. John, 08/16/2018 11:50 AM
23452
23456
24540
24558

Related issues

Blocked by FreeNAS - Feature #40500: Refactor how memory is accountedDone

History

#1 Updated by Dru Lavigne over 1 year ago

  • Target version changed from Backlog to 11.2-BETA3

#2 Updated by Vaibhav Chauhan over 1 year ago

  • Assignee changed from Release Council to Vaibhav Chauhan

#3 Updated by Vaibhav Chauhan over 1 year ago

  • Status changed from Unscreened to Blocked
  • Reason for Blocked set to Dependent on a related task to be completed

#4 Updated by Vaibhav Chauhan over 1 year ago

#5 Updated by Vaibhav Chauhan over 1 year ago

  • Status changed from Blocked to In Progress

#6 Updated by Vaibhav Chauhan over 1 year ago

#7 Updated by Erin Clark over 1 year ago

  • Status changed from In Progress to Ready for Testing

#8 Updated by Dru Lavigne over 1 year ago

  • Subject changed from VM memory check not made at step 7 of wizard, but only when trying to start VM. to Perform VM memory check at the beginning of the new UI wizard
  • Reason for Blocked deleted (Dependent on a related task to be completed)
  • Needs Merging changed from Yes to No

#10 Updated by Dru Lavigne over 1 year ago

  • Subject changed from Perform VM memory check at the beginning of the new UI wizard to Perform VM memory check at the beginning of the create VM wizard in the new UI

#11 Updated by Aaron St. John over 1 year ago

24540

Tested on FreeNAS-11.2-MASTER-201808160915

Test Procedure:
1. Go to VMs
2. Create a VM. Go through the wizard until "CPU and Memory" is reached.
3. Specify a memory value larger than what the host system has.
4. Observe error message (see screenshot).

#12 Updated by Aaron St. John over 1 year ago

  • Needs Doc changed from Yes to No

#14 Updated by Aaron St. John over 1 year ago

  • Status changed from Passed Testing to Failed Testing
  • Needs QA changed from No to Yes

Tested on FreeNAS-11.2-MASTER-201808160915

Even though it performed a memory check I still got this error (See screenshot. See more info pasted below)

To reproduce:
By trial and error I found the most amount of memory I could use that was accepted by the memory check from the wizard (in my case 8414MiB).
Went through the installation and started the VM. I then followed the steps to download/install Fedora into the VM. Finished setting up Fedora and it asked me to reboot.
Upon shutting down the VM and refreshing the page I was unable to start back to VM and received the error.

System information:
The host system has 16384MiB of memory equipped.

Error: Traceback (most recent call last):
File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 155, in call_method
result = await self.middleware.call_method(self, message)
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 110, in next
return self.gen.send(None)
File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 1023, in call_method
return await self._call(message['method'], serviceobj, methodobj, params, app=app, io_thread=False)
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 110, in next
return self.gen.send(None)
File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 963, in call
return await methodobj(*args)
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 110, in next
return self.gen.send(None)
File "/usr/local/lib/python3.6/site-packages/middlewared/schema.py", line 664, in nf
return await f(*args, **kwargs)
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 110, in next
return self.gen.send(None)
File "/usr/local/lib/python3.6/site-packages/middlewared/plugins/vm.py", line 1129, in start
await self.
_init_guest_vmemory(vm, overcommit=overcommit)
File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 110, in next
return self.gen.send(None)
File "/usr/local/lib/python3.6/site-packages/middlewared/plugins/vm.py", line 880, in __init_guest_vmemory
raise CallError(f'Cannot guarantee memory for guest {vm["name"]}')
middlewared.service_exception.CallError: [EFAULT] Cannot guarantee memory for guest testing

#15 Updated by Aaron St. John over 1 year ago

  • File VM_memory_check.png added

#16 Updated by Aaron St. John over 1 year ago

  • File deleted (VM_memory_check.png)

#17 Updated by Aaron St. John over 1 year ago

24558

#18 Updated by Aaron St. John over 1 year ago

  • Status changed from Failed Testing to Passed Testing
  • Needs QA changed from Yes to No

After a discussion with Vaibhav, it was said that memory is complicated and there's not a 100% accuracy for determing the max amount of memory a VM could use for it to be functional. For sake of the original ticket, it passes testing. The desired behaviour happens (a memory check is performed).

#19 Updated by Dru Lavigne over 1 year ago

  • Needs Doc changed from No to Yes

#20 Updated by Dru Lavigne over 1 year ago

  • Status changed from Passed Testing to Done

#21 Updated by Dru Lavigne over 1 year ago

  • Needs Doc changed from Yes to No

Also available in: Atom PDF