Project

General

Profile

Bug #40584

Strip subnet from management URL for iocage plugins

Added by Jurgen Segaert about 2 years ago. Updated about 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Brandon Schneider
Category:
Middleware
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

This is a follow up, related to but not a duplicate of, https://redmine.ixsystems.com/issues/39203, for plugins that do provide a proper management page.

To reproduce, create an plugin with shared IP:

root@FreenasVBox:~ # iocage fetch --plugins -n plex ip4_addr="em0|192.168.0.210/24" 
Plugin: Plex
  Official Plugin: True
  Using RELEASE: 11.2-RELEASE
  Post-install Artifact: https://github.com/freenas/iocage-plugin-plexmediaserver.git
  These pkgs will be installed:
    - multimedia/plexmediaserver
Fetching artifact...
Running post_install.sh

Command output:
plexmediaserver_enable:  -> YES
Starting plexmediaserver.

Admin Portal:
http://192.168.0.210:32400/web

Note that above it correctly states the admin portal is: http://192.168.0.210:32400/web

However, going back to iocage, it states that the admin URL is: http://192.168.0.210/24:32400/web (note the subnet /24 is incorrectly part of the URL)

root@FreenasVBox:~ # iocage list -P
+-----+------+------+-------+----------+--------------+----------------------+-----+----------+-----------------------------------+
| JID | NAME | BOOT | STATE |   TYPE   |   RELEASE    |         IP4          | IP6 | TEMPLATE |              PORTAL               |
+=====+======+======+=======+==========+==============+======================+=====+==========+===================================+
| 4   | plex | on   | up    | pluginv2 | 11.2-RELEASE | em0|192.168.0.210/24 | -   | -        | http://192.168.0.210/24:32400/web |
+-----+------+------+-------+----------+--------------+----------------------+-----+----------+-----------------------------------+

This very URL is also used when one clicks the "Management" function under menu "Plugins>Installed" in the new UI.

The good news is that I already fixed this upstream in iocage via this pull request: https://github.com/iocage/iocage/pull/586

Can this PR please be added to the FreeNAS fork of iocage?


Related issues

Related to FreeNAS - Bug #42791: Management URL for plugin is wrongClosed

History

#1 Updated by Dru Lavigne about 2 years ago

  • Category changed from Build system to GUI (new)
  • Assignee changed from Release Council to Erin Clark
  • Target version changed from Backlog to 11.2-BETA3

#2 Updated by Erin Clark about 2 years ago

  • Assignee changed from Erin Clark to Lola Yang

#3 Updated by Lola Yang about 2 years ago

  • Category changed from GUI (new) to Middleware
  • Assignee changed from Lola Yang to Brandon Schneider

#5 Updated by Brandon Schneider about 2 years ago

  • Status changed from Unscreened to In Progress

PR: https://github.com/freenas/iocage/pull/11
DESC: Strip subnet mask off plugin IP portal
RISK: Low
ACCEPTANCE: Make sure the subnet mask is not present after creating a shared IP plugin

#6 Updated by Dru Lavigne about 2 years ago

  • Status changed from In Progress to Ready for Testing
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#7 Updated by Dru Lavigne about 2 years ago

  • Related to Bug #42791: Management URL for plugin is wrong added

#8 Updated by Michael Reynolds about 2 years ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

Installed the Plex plugin
Went to the management URL
The URL http://10.231.5.254:32400/web/index.html is used
The subnet is properly stripped.

#9 Updated by Dru Lavigne about 2 years ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF