Project

General

Profile

Bug #41068

Fix exception when dismissing alert that has gone away

Added by William Grzybowski about 2 years ago. Updated about 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Vladimir Vinogradenko
Category:
Middleware
Target version:
Seen in:
Severity:
Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

[2018/08/08 03:23:59] (WARNING) application.call_method():181 - Exception while calling alert.dismiss(*['A;NTPStatus;["ntp_flapping"]'])
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 154, in call_method
    result = await self.middleware.call_method(self, message)
  File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 129, in throw
    return self.gen.throw(type, value, traceback)
  File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 1013, in call_method
    return await self._call(message['method'], serviceobj, methodobj, params, app=app, io_thread=False)
  File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 129, in throw
    return self.gen.throw(type, value, traceback)
  File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 967, in _call
    return await run_method(methodobj, *args)
  File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 129, in throw
    return self.gen.throw(type, value, traceback)
  File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 905, in run_in_thread
    return await self.run_in_executor(self.__threadpool, method, *args, **kwargs)
  File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 129, in throw
    return self.gen.throw(type, value, traceback)
  File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 902, in run_in_executor
    return await loop.run_in_executor(pool, functools.partial(method, *args, **kwargs))
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/local/lib/python3.6/site-packages/middlewared/schema.py", line 662, in nf
    return f(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/middlewared/plugins/alert.py", line 145, in dismiss
    alert = self.alerts[node][source][key]
KeyError: '["ntp_flapping"]'

History

#1 Updated by Bug Clerk about 2 years ago

  • Status changed from Unscreened to In Progress

#2 Updated by Bug Clerk about 2 years ago

  • Status changed from In Progress to Ready for Testing

#3 Updated by Dru Lavigne about 2 years ago

  • Subject changed from Traceback dismissing ntp alert to Fix exception when dismissing alert that has gone away
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#4 Updated by Timothy Moore II about 2 years ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

Testing with FreeNAS system updated to FreeNAS-11.2-MASTER-201808310859:

Go to Storage > Pools > Add. Create a mirror pool with two disks. Offline one disk and wait for alert to appear. After alert appears, online the disk. Open alerts tab and dismiss the alert and clear all alerts. No traceback generated or unexpected behavior seen.

#5 Updated by Dru Lavigne about 2 years ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF