Project

General

Profile

Bug #41296

Fix nginx escape that prevented access to web UI in Nightlies

Added by Tom Fjader about 2 years ago. Updated about 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
William Grzybowski
Category:
Middleware
Severity:
High
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

The UI is not accessible in latest nightlies (e.g. FreeNAS-11.2-MASTER-201808110857) because nginx cannot start. In the logs in file /var/log/nginx/error.log I can find:

2018/08/12 15:44:54 [emerg] 4367#101366: invalid condition "~" in /usr/local/etc/nginx/nginx.conf:104

I commented out the "if ( ~ ^POST$ )..." code block around line 104 in /usr/local/etc/nginx/nginx.conf, and nginx can be started, and the UI seems to work, but that error.log file now fills up with lines like:

Aug 12 15:47:46 freenas11-vm nginx: 2018/08/12 15:47:46 [error] 4590#101368: *13 directory index of "/usr/local/www/webui/assets/images/" is forbidden, client: 192.168.100.131, server: localhost, request: "GET /ui/assets/images/ HTTP/1.1", host: "192.168.100.250", referrer: "http://192.168.100.250/ui/" 


Related issues

Has duplicate FreeNAS - Bug #41316: Error in nginx.conf has broken the nightliesClosed

Associated revisions

Revision d3dd9122 (diff)
Added by William Grzybowski about 2 years ago

fix(nginx): var escaping Ticket: #41296

History

#1 Updated by William Grzybowski about 2 years ago

  • Category changed from GUI (new) to Middleware
  • Status changed from Unscreened to Not Started
  • Assignee changed from Release Council to William Grzybowski
  • Target version changed from Backlog to Master - FreeNAS Nightlies
  • Severity changed from New to High

#2 Avatar?id=46365&size=24x24 Updated by hans Cappon about 2 years ago

Tom Fjader wrote:

The UI is not accessible in latest nightlies (e.g. FreeNAS-11.2-MASTER-201808110857) because nginx cannot start. In the logs in file /var/log/nginx/error.log I can find:
[...]

I commented out the "if ( ~ ^POST$ )..." code block around line 104 in /usr/local/etc/nginx/nginx.conf, and nginx can be started, and the UI seems to work, but that error.log file now fills up with lines like:
[...]

I have same issue (is this correct way? i couldn't find a button to support this issue.)

#3 Updated by William Grzybowski about 2 years ago

  • Status changed from Not Started to Ready for Testing

#4 Updated by Dru Lavigne about 2 years ago

  • Has duplicate Bug #41316: Error in nginx.conf has broken the nightlies added

#5 Updated by Dru Lavigne about 2 years ago

  • Subject changed from Web UI not accessible because nginx cannot start to Fix nginx escape that prevented access to web UI in Nightlies
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#6 Updated by Dru Lavigne about 2 years ago

  • Status changed from Ready for Testing to Done
  • Needs QA changed from Yes to No

Also available in: Atom PDF