Project

General

Profile

Bug #41450

Ensure all new UI components that use core.service use the OnDestroy lifecycle hook to properly unregister

Added by William Grzybowski about 2 years ago. Updated about 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Damian Szidiropulosz
Category:
GUI (new)
Target version:
Seen in:
Severity:
Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

If you move away from Dashboard page (e.g. go to Services) you will still see websockets requests of stats.get_data being made periodically.

{"id":"f3c42108-d536-bf07-9eac-e09139d51e55","msg":"method","method":"stats.get_data","params":[[{"source":"interface-em0","type":"if_packets","dataset":"rx"},{"source":"interface-em0","type":"if_packets","dataset":"tx"},{"source":"interface-em0","type":"if_octets","dataset":"rx"},{"source":"interface-em0","type":"if_octets","dataset":"tx"},{"source":"interface-em0","type":"if_errors","dataset":"rx"},{"source":"interface-em0","type":"if_errors","dataset":"tx"}],{"step":"10","start":"now-10m"}]}

This bring unnecessary load to middleware and should be avoided.

History

#1 Updated by Dru Lavigne about 2 years ago

  • Assignee changed from Release Council to Erin Clark

#2 Updated by Erin Clark about 2 years ago

  • Assignee changed from Erin Clark to Damian Szidiropulosz

#4 Updated by Dru Lavigne about 2 years ago

  • Severity changed from New to Medium

#5 Updated by Damian Szidiropulosz about 2 years ago

PR 1167 fixes this.

#6 Updated by Dru Lavigne about 2 years ago

  • Subject changed from WebUI will periodically call stats.get_data even if not on dashboard to Ensure all new UI components that use core.service use the OnDestroy lifecycle hook to properly unregister
  • Status changed from Unscreened to In Progress
  • Needs Doc changed from Yes to No

#7 Updated by Erin Clark about 2 years ago

  • Status changed from In Progress to Ready for Testing

#8 Updated by Erin Clark about 2 years ago

I would like to note that I do still see this but only on VMs, it does not happen with mine or Damian's mini

#9 Updated by Dru Lavigne about 2 years ago

  • Needs Merging changed from Yes to No

#10 Updated by Bonnie Follweiler about 2 years ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

Test Passed in FreeNAS-11.2-MASTER-201809040858

#11 Updated by Dru Lavigne about 2 years ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF