Project

General

Profile

Bug #41580

Make sure VM sector size is an int

Added by William Grzybowski over 1 year ago. Updated over 1 year ago.

Status:
Done
Priority:
No priority
Assignee:
William Grzybowski
Category:
Middleware
Target version:
Seen in:
Severity:
Low Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

[2018/08/14 12:02:37] (WARNING) application.call_method():181 - Exception while calling vm.start(*[1])
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 154, in call_method
    result = await self.middleware.call_method(self, message)
  File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 110, in __next__
    return self.gen.send(None)
  File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 1013, in call_method
    return await self._call(message['method'], serviceobj, methodobj, params, app=app, io_thread=False)
  File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 110, in __next__
    return self.gen.send(None)
  File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 953, in _call
    return await methodobj(*args)
  File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 110, in __next__
    return self.gen.send(None)
  File "/usr/local/lib/python3.6/site-packages/middlewared/schema.py", line 658, in nf
    return await f(*args, **kwargs)
  File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 110, in __next__
    return self.gen.send(None)
  File "/usr/local/lib/python3.6/site-packages/middlewared/plugins/vm.py", line 1020, in start
    await self._manager.start(id)
  File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 110, in __next__
    return self.gen.send(None)
  File "/usr/local/lib/python3.6/site-packages/middlewared/plugins/vm.py", line 53, in start
    list(done)[0].result()
  File "/usr/local/lib/python3.6/asyncio/coroutines.py", line 126, in send
    return self.gen.send(value)
  File "/usr/local/lib/python3.6/site-packages/middlewared/plugins/vm.py", line 137, in run
    if disk_sector_size > 0:
TypeError: '>' not supported between instances of 'str' and 'int'

Acceptance Criteria
Create a VM with a custom disk sector size and try to start it

Risk
Low, simple bug fix

https://sentry.ixsystems.com/ixsystems/freenas-middleware/issues/12566/


Related issues

Related to FreeNAS - Bug #44460: Docker VM Not Recognizing the CD Boot in old IUClosed
Has duplicate FreeNAS - Bug #44130: Bug while booting VMClosed

Associated revisions

Revision eccaacf9 (diff)
Added by William Grzybowski over 1 year ago

fix(middlewared/vm): make sure sectorsize is an int Ticket: #41580

Revision 6a05e829 (diff)
Added by William Grzybowski over 1 year ago

fix(middlewared/vm): make sure sectorsize is an int Ticket: #41580

History

#1 Updated by Bug Clerk over 1 year ago

  • Status changed from Unscreened to In Progress

#2 Updated by William Grzybowski over 1 year ago

  • Status changed from In Progress to Ready for Testing

#3 Updated by Dru Lavigne over 1 year ago

  • Subject changed from Failed to start VM with custom disk sector size to Make sure VM sector size is an int
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#4 Updated by Dru Lavigne over 1 year ago

  • Has duplicate Bug #44130: Bug while booting VM added

#5 Updated by Jeff Ervin over 1 year ago

  • Status changed from Ready for Testing to Blocked
  • Reason for Blocked set to Dependent on a related task to be completed

Until https://redmine.ixsystems.com/issues/44460 is fixed, I am unable to test this ticket.

#6 Updated by Jeff Ervin over 1 year ago

  • Related to Bug #44460: Docker VM Not Recognizing the CD Boot in old IU added

#7 Updated by William Grzybowski over 1 year ago

Jeff Ervin wrote:

Until https://redmine.ixsystems.com/issues/44460 is fixed, I am unable to test this ticket.

Why? You dont need a Docker VM to test this.

#8 Updated by Jeff Ervin over 1 year ago

  • Reason for Blocked deleted (Dependent on a related task to be completed)

Until https://redmine.ixsystems.com/issues/44460 is fixed, I am unable to test this ticket.

William Grzybowski wrote:

Jeff Ervin wrote:

Until https://redmine.ixsystems.com/issues/44460 is fixed, I am unable to test this ticket.

Why? You dont need a Docker VM to test this.

The only area in which I can adjust the sector size is via a Docker VM. What am I missing, I'm not seeing that option anywhere else.

#9 Updated by William Grzybowski over 1 year ago

Jeff Ervin wrote:

Until https://redmine.ixsystems.com/issues/44460 is fixed, I am unable to test this ticket.

William Grzybowski wrote:

Jeff Ervin wrote:

Until https://redmine.ixsystems.com/issues/44460 is fixed, I am unable to test this ticket.

Why? You dont need a Docker VM to test this.

The only area in which I can adjust the sector size is via a Docker VM. What am I missing, I'm not seeing that option anywhere else.

Sector size is available in a regular VM when editing the Disk device.

#10 Updated by Jeff Ervin over 1 year ago

  • Status changed from Blocked to Passed Testing
  • Needs QA changed from Yes to No

#12 Updated by Dru Lavigne over 1 year ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF