Project

General

Profile

Bug #42887

Improve new user creation in New UI

Added by Michael Reynolds almost 2 years ago. Updated almost 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Vaibhav Chauhan
Category:
GUI (new)
Target version:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Multiple issues when creating a new user. (Using the 8-24 Nightly)

Username
Usernames must be alphanumeric and eight characters or less.
We disallow invalid characters but do not inform the user until after clicking Save.
See UserNameValidator-2018-08-24.png

Add Username validator to:
Not allow anything but alphanumeric characters a hyphen1 and a dollar sign2.
[1] Do not allow a hyphen to be the first character
[2] Only allow a $ at the end of a username
Do not allow entry of passwords that are >= 9

Passwords
Question marks are not allowed in a password but the password field allows a ? to be entered and the error is not shown until after clicking the Save button.

Add a validator to disallow entry of a ?
See PasswordValidator-2018-08-24.png

Enable password login
The password tooltip states "Required unless Enable password login is No. Passwords cannot contain a ?."
Enable password login is a drop-down in the bottom right of the Add New User form and is hard to find at first.
See EnablePasswordLogin-2018-08-24.png

Needs Design Doc and discussion
The Enable password login should be changed to a checkbox.
The checkbox should be moved to be below the Email field and above the Password field or perhaps to the left of the Password field.
The checkbox should be enabled by default.
Unchecking should hide the Password and Confirm Password fields

The Lock User and Permit Sudo checkboxes are tied to the Enable password login option.
Should both of these options be moved up to the Password field area with the Enable password login checkbox?
Both options are already hidden when Enable Password login is set to No.
If the Enable password Login is unset, both options should continue to be hidden and shown when set.

UserNameValidator-2018-08-24.png (30 KB) UserNameValidator-2018-08-24.png Michael Reynolds, 08/24/2018 12:27 PM
PasswordValidator-2018-08-24.png (15.1 KB) PasswordValidator-2018-08-24.png Michael Reynolds, 08/24/2018 12:27 PM
EnablePasswordLogin-2018-08-24.png (47.1 KB) EnablePasswordLogin-2018-08-24.png Michael Reynolds, 08/24/2018 12:27 PM
25649
25655
25661

Related issues

Related to FreeNAS - Bug #52116: Warn if username is greater than 8 characters but accept up to 16 charactersDone

History

#2 Updated by Erin Clark almost 2 years ago

  • Status changed from Unscreened to Screened

#3 Updated by Dru Lavigne almost 2 years ago

  • Target version changed from Backlog to 11.2-RC1

#4 Updated by Erin Clark almost 2 years ago

  • Assignee changed from Erin Clark to Vaibhav Chauhan

#5 Updated by Vaibhav Chauhan almost 2 years ago

Michael Reynolds wrote:

Multiple issues when creating a new user. (Using the 8-24 Nightly)

Username
Usernames must be alphanumeric and eight characters or less.
We disallow invalid characters but do not inform the user until after clicking Save.
See UserNameValidator-2018-08-24.png

Add Username validator to:
Not allow anything but alphanumeric characters a hyphen1 and a dollar sign2.
[1] Do not allow a hyphen to be the first character
[2] Only allow a $ at the end of a username
Do not allow entry of passwords that are >= 9

Passwords
Question marks are not allowed in a password but the password field allows a ? to be entered and the error is not shown until after clicking the Save button.

Add a validator to disallow entry of a ?
See PasswordValidator-2018-08-24.png

https://github.com/freenas/webui/pull/1272

I have decided not to implement below as reasons specified inline.

Enable password login
The password tooltip states "Required unless Enable password login is No. Passwords cannot contain a ?."
Enable password login is a drop-down in the bottom right of the Add New User form and is hard to find at first.
See EnablePasswordLogin-2018-08-24.png

Needs Design Doc and discussion
The Enable password login should be changed to a checkbox.

This cause cyclic dependency, we cant do that with current setup

The checkbox should be moved to be below the Email field and above the Password field or perhaps to the left of the Password field.

I think it makes sense for to keep things as it is.

The checkbox should be enabled by default.

matching legacy UI

Unchecking should hide the Password and Confirm Password fields

matching legacy UI

The Lock User and Permit Sudo checkboxes are tied to the Enable password login option.
Should both of these options be moved up to the Password field area with the Enable password login checkbox?
Both options are already hidden when Enable Password login is set to No.
If the Enable password Login is unset, both options should continue to be hidden and shown when set.

again cyclic dependency, cant do this with current setup

#6 Updated by Vaibhav Chauhan almost 2 years ago

  • Status changed from Screened to In Progress

#7 Updated by Lola Yang almost 2 years ago

  • Status changed from In Progress to Ready for Testing
  • Needs Merging changed from Yes to No

#8 Updated by Aaron St. John almost 2 years ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

Tested on FreeNAS-11.2-MASTER-201810020854

Changes seem to be present.

#9 Updated by Aaron St. John almost 2 years ago

  • Needs Doc changed from Yes to No

#10 Updated by Dru Lavigne almost 2 years ago

  • Status changed from Passed Testing to Done

#11 Updated by Dru Lavigne over 1 year ago

  • Related to Bug #52116: Warn if username is greater than 8 characters but accept up to 16 characters added

Also available in: Atom PDF