FreeNAS

Michael Reynolds wrote:

Multiple issues when creating a new user. (Using the 8-24 Nightly)

Username
Usernames must be alphanumeric and eight characters or less.
We disallow invalid characters but do not inform the user until after clicking Save.
See UserNameValidator-2018-08-24.png

Add Username validator to:
Not allow anything but alphanumeric characters a hyphen¹ and a dollar sign².
[1] Do not allow a hyphen to be the first character
[2] Only allow a $ at the end of a username
Do not allow entry of passwords that are >= 9

Passwords
Question marks are not allowed in a password but the password field allows a ? to be entered and the error is not shown until after clicking the Save button.

Add a validator to disallow entry of a ?
See PasswordValidator-2018-08-24.png

https://github.com/freenas/webui/pull/1272

I have decided not to implement below as reasons specified inline.

Enable password login
The password tooltip states "Required unless Enable password login is No. Passwords cannot contain a ?."
Enable password login is a drop-down in the bottom right of the Add New User form and is hard to find at first.
See EnablePasswordLogin-2018-08-24.png

Needs Design Doc and discussion
The Enable password login should be changed to a checkbox.

This cause cyclic dependency, we cant do that with current setup

The checkbox should be moved to be below the Email field and above the Password field or perhaps to the left of the Password field.

I think it makes sense for to keep things as it is.

The checkbox should be enabled by default.

matching legacy UI

Unchecking should hide the Password and Confirm Password fields

matching legacy UI

The Lock User and Permit Sudo checkboxes are tied to the Enable password login option.
Should both of these options be moved up to the Password field area with the Enable password login checkbox?
Both options are already hidden when Enable Password login is set to No.
If the Enable password Login is unset, both options should continue to be hidden and shown when set.

again cyclic dependency, cant do this with current setup