Project

General

Profile

Bug #43591

Fix logic for validating disks when extending pool in new UI

Added by Michael Reynolds about 2 years ago. Updated almost 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Erin Clark
Category:
GUI (new)
Target version:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Storage:Pools -> Expand a Pool drop-down -> Pool Operations (gear icon) -> Extend

Confirm the warning.

The EXTEND button is not enabled (good)

Add an available disk from the Available Disks to the Data VDevs
The EXTEND button is enabled (good)

Remove the disk from the Data VDevs section
The EXTEND button stays enabled and is clickable (not good)

Clicking EXTEND with no disks added to the Data VDevs opens the Warning dialog about disk contents being erased.
Check Confirm and click CREATE POOL

The Please Wait spinner dialog opens and looks like something is happening but from what I can tell, nothing actually does.

middlewared.log gives
[2018/08/29 20:44:03] (DEBUG) ServiceService._simplecmd():276 - Calling: reload(disk)
[2018/08/29 20:44:03] (DEBUG) ServiceService._simplecmd():276 - Calling: restart(collectd)
[2018/08/29 20:44:04] (DEBUG) ServiceService._simplecmd():276 - Calling: restart(cron)
[2018/08/29 20:44:04] (DEBUG) ServiceService._simplecmd():276 - Calling: restart(smartd)

Nothing has changed with the available disks nor the pool so clicking EXTEND with no disks selected appears to be harmless.

History

#1 Updated by Dru Lavigne about 2 years ago

  • Target version changed from Backlog to 11.2-RC1

#2 Updated by Erin Clark about 2 years ago

  • Status changed from Unscreened to In Progress

https://github.com/freenas/webui/pull/1213 fixed in this PR, however note that it is still possible to extend if data vdevs are empty but it is not possible to extend if there are no vdevs with disks (i.e. you can still add spares or cache or log without adding data)

#3 Updated by Lola Yang about 2 years ago

  • Status changed from In Progress to Ready for Testing
  • Needs Merging changed from Yes to No

#4 Updated by Dru Lavigne about 2 years ago

  • Subject changed from EXTEND button can be clicked with no disks added to Data VDevs in new UI to Fix logic for validating disks when extending pool in new UI
  • Needs Doc changed from Yes to No

#5 Updated by Jeff Ervin almost 2 years ago

32155
32166
32169

Test Passed FreeNAS-11.2-MASTER-201809270855

Extend button available when a drive is added toe Data VDevs, Extend button unavailable when there is no disk selected in the Data VDevs

#6 Updated by Dru Lavigne almost 2 years ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF