Project

General

Profile

Bug #44724

Use appropriate units in the Dashboard Disks widget of new UI

Added by Warren Block about 2 years ago. Updated about 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Dennis Mullen
Category:
GUI (new)
Target version:
11.2-RC1
Seen in:
Master - FreeNAS Nightlies
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Process disk and pool capacity numbers on the dashboard:

1. Commify (add commas or periods depending on user locale setting)

2. Humanize numbers: use units appropriate to the magnitude of the number shown.
if val > 1 TiB, show in units of TiB
else if val > 1 GiB, show in units of GiB
else show in units of MiB

3. Two decimal places are okay. One might be adequate and easier to read.

dashboard-disks.png (14.8 KB) dashboard-disks.png Warren Block, 09/05/2018 07:55 AM
dashboard-fix.png (150 KB) dashboard-fix.png Aaron St. John, 09/21/2018 11:03 AM
28389
31197

History

#1 Updated by Erin Clark about 2 years ago

  • Assignee changed from Erin Clark to Dennis Mullen
  • Target version changed from Backlog to 11.2-RC1

#2 Updated by Dennis Mullen about 2 years ago

  • Status changed from Unscreened to In Progress

#3 Updated by Dennis Mullen about 2 years ago

PR 1230

#4 Updated by Lola Yang about 2 years ago

  • Status changed from In Progress to Ready for Testing
  • Needs Merging changed from Yes to No

#5 Updated by Dru Lavigne about 2 years ago

  • Subject changed from Commify and humanize dashboard pools/disks area to Use appropriate units in the Dashboard Disks widget of new UI
  • Needs Doc changed from Yes to No

#6 Updated by Aaron St. John about 2 years ago

31197

Tested on FreeNAS-11.2-MASTER-201809210904

Test case:
1. Go to dashboard.
2. Observe that the fix is present. (see screenshot)

#7 Updated by Dru Lavigne about 2 years ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF