Project

General

Profile

Bug #45805

Fix traceback on jail delete

Added by William Grzybowski almost 2 years ago. Updated almost 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Waqar Ahmed
Category:
Middleware
Target version:
Seen in:
Severity:
Low Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/concurrent/futures/process.py", line 175, in _process_worker
    r = call_item.fn(*call_item.args, **call_item.kwargs)
  File "/usr/local/lib/python3.6/site-packages/middlewared/worker.py", line 122, in main_worker
    res = loop.run_until_complete(coro)
  File "/usr/local/lib/python3.6/asyncio/base_events.py", line 468, in run_until_complete
    return future.result()
  File "/usr/local/lib/python3.6/site-packages/middlewared/worker.py", line 82, in _run
    return await self._call(f'{service_name}.{method}', serviceobj, methodobj, params=args, job=job)
  File "/usr/local/lib/python3.6/site-packages/middlewared/worker.py", line 75, in _call
    return methodobj(*params)
  File "/usr/local/lib/python3.6/site-packages/middlewared/worker.py", line 75, in _call
    return methodobj(*params)
  File "/usr/local/lib/python3.6/site-packages/middlewared/schema.py", line 668, in nf
    return f(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/middlewared/plugins/jail.py", line 245, in do_delete
    iocage.destroy_jail()
  File "/usr/local/lib/python3.6/site-packages/iocage_lib/iocage.py", line 719, in destroy_jail
    ioc_destroy.IOCDestroy().destroy_jail(path)
  File "/usr/local/lib/python3.6/site-packages/iocage_lib/ioc_destroy.py", line 259, in destroy_jail
    f"{self.pool}/iocage/{dataset_type}/{uuid}")
  File "/usr/local/lib/python3.6/site-packages/iocage_lib/ioc_destroy.py", line 225, in __destroy_parse_datasets__
    self.__destroy_leftovers__(dataset, clean=clean)
  File "/usr/local/lib/python3.6/site-packages/iocage_lib/ioc_destroy.py", line 121, in __destroy_leftovers__
    os.remove(file)
FileNotFoundError: [Errno 2] No such file or directory: '/mnt/iocage/log/gitlab-console.log'

{
'id': '5182b679-22bf-e1cf-64f3-c901b314b77c', 
'method': 'jail.do_delete', 
'msg': 'method', 
'params': [
'gitlab'
]
}

https://sentry.ixsystems.com/ixsystems/freenas-middleware/issues/14831/

Jail Delete.png (29.1 KB) Jail Delete.png Jeff Ervin, 09/24/2018 12:50 PM
Jail Delete 2.png (38.8 KB) Jail Delete 2.png Jeff Ervin, 09/24/2018 12:50 PM
31560
31571

History

#1 Updated by Waqar Ahmed almost 2 years ago

  • Status changed from Unscreened to In Progress

#2 Updated by Waqar Ahmed almost 2 years ago

  • Status changed from In Progress to Ready for Testing

PR - https://github.com/freenas/iocage/pull/29

The original issue couldn't be reproduced, so for testing this ticket it should be ensured that jail deletion doesn't result in a traceback.

#3 Updated by Dru Lavigne almost 2 years ago

  • Subject changed from Traceback on jail delete to Fix traceback on jail delete
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#4 Updated by Jeff Ervin almost 2 years ago

31560
31571

Test Passed FreeNAS-11.2-MASTER-201809240851

#5 Updated by Dru Lavigne almost 2 years ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF