Project

General

Profile

Bug #45838

Improve validation for iocage jail CRUD methods

Added by William Grzybowski about 2 years ago. Updated almost 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Waqar Ahmed
Category:
Middleware
Target version:
Seen in:
Severity:
Low Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/concurrent/futures/process.py", line 175, in _process_worker
    r = call_item.fn(*call_item.args, **call_item.kwargs)
  File "/usr/local/lib/python3.6/site-packages/middlewared/worker.py", line 122, in main_worker
    res = loop.run_until_complete(coro)
  File "/usr/local/lib/python3.6/asyncio/base_events.py", line 468, in run_until_complete
    return future.result()
  File "/usr/local/lib/python3.6/site-packages/middlewared/worker.py", line 82, in _run
    return await self._call(f'{service_name}.{method}', serviceobj, methodobj, params=args, job=job)
  File "/usr/local/lib/python3.6/site-packages/middlewared/worker.py", line 75, in _call
    return methodobj(*params)
  File "/usr/local/lib/python3.6/site-packages/middlewared/worker.py", line 75, in _call
    return methodobj(*params)
  File "/usr/local/lib/python3.6/site-packages/middlewared/schema.py", line 668, in nf
    return f(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/middlewared/plugins/jail.py", line 456, in start
    iocage.start()
  File "/usr/local/lib/python3.6/site-packages/iocage_lib/iocage.py", line 1621, in start
    callback=self.callback
  File "/usr/local/lib/python3.6/site-packages/iocage_lib/ioc_start.py", line 65, in __init__
    self.__start_jail__()
  File "/usr/local/lib/python3.6/site-packages/iocage_lib/ioc_start.py", line 405, in __start_jail__
    vnet_err = self.start_network(vnet)
  File "/usr/local/lib/python3.6/site-packages/iocage_lib/ioc_start.py", line 575, in start_network
    err = self.start_network_interface_vnet(nic, net_configs, jid)
  File "/usr/local/lib/python3.6/site-packages/iocage_lib/ioc_start.py", line 627, in start_network_interface_vnet
    membermtu, jid)
  File "/usr/local/lib/python3.6/site-packages/iocage_lib/ioc_start.py", line 653, in start_network_vnet_iface
    mac_a, mac_b = self.__start_generate_vnet_mac__(nic)
  File "/usr/local/lib/python3.6/site-packages/iocage_lib/ioc_start.py", line 835, in __start_generate_vnet_mac__
    mac_a, mac_b = mac.split(",")
ValueError: not enough values to unpack (expected 2, got 1)

https://sentry.ixsystems.com/ixsystems/freenas-middleware/issues/12860/


Related issues

Related to FreeNAS - Bug #46436: Change wording for jail creation advanced fieldDone
Related to FreeNAS - Bug #47151: Fix traceback when listing jailsDone

Associated revisions

Revision 0cfe9f00 (diff)
Added by Waqar Ahmed about 2 years ago

Improve validation for jail CRUD Methods This commit improves the validation process for jail CRUD Methods adding support for verifying vnet mac addresses. Ticket: #45838

Revision a8777170 (diff)
Added by Waqar Ahmed about 2 years ago

Improve validation for jail CRUD Methods This commit improves the validation process for jail CRUD Methods adding support for verifying vnet mac addresses. Ticket: #45838

Revision b246d49c (diff)
Added by Waqar Ahmed about 2 years ago

Improve validation for jail CRUD Methods This commit improves the validation process for jail CRUD Methods adding support for verifying vnet mac addresses. Ticket: #45838

Revision 35f9ed71 (diff)
Added by Waqar Ahmed about 2 years ago

Improve validation for jail CRUD Methods This commit improves the validation process for jail CRUD Methods adding support for verifying vnet mac addresses. Ticket: #45838

History

#1 Updated by Waqar Ahmed about 2 years ago

  • Status changed from Unscreened to In Progress

#2 Updated by Waqar Ahmed about 2 years ago

  • Related to Bug #46436: Change wording for jail creation advanced field added

#3 Updated by Bug Clerk about 2 years ago

  • Status changed from In Progress to Ready for Testing

#4 Updated by Waqar Ahmed about 2 years ago

  • Status changed from Ready for Testing to In Progress

#5 Updated by Waqar Ahmed about 2 years ago

  • Status changed from In Progress to Ready for Testing

#6 Updated by Dru Lavigne about 2 years ago

  • Subject changed from Traceback starting vnet jail with missing mac to Improve validation for iocage jail CRUD methods
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#7 Updated by Waqar Ahmed about 2 years ago

  • Related to Bug #47151: Fix traceback when listing jails added

#8 Updated by Bonnie Follweiler almost 2 years ago

  • Status changed from Ready for Testing to Passed Testing

#10 Updated by Dru Lavigne almost 2 years ago

  • Status changed from Passed Testing to Done
  • Needs QA changed from Yes to No

Also available in: Atom PDF