Project

General

Profile

Bug #46425

Alert if iocage pool is not activated before performing any plugin or jail operations in UI

Added by Brandon Schneider about 2 years ago. Updated almost 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Lola Yang
Category:
GUI (new)
Target version:
Seen in:
Severity:
Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Lola: Middleware will handle the use case of a dev using the CLI to try to access this method, but the UI needs to require a pool be activated before any plugin or jail operations can be done, including listing the plugins. Copying the ticket below so you have context.

RuntimeError: Please specify a pool to activate with iocage activate POOL
  File "middlewared/main.py", line 155, in call_method
    result = await self.middleware.call_method(self, message)
  File "middlewared/main.py", line 1033, in call_method
    return await self._call(message['method'], serviceobj, methodobj, params, app=app, io_thread=False)
  File "middlewared/main.py", line 970, in _call
    return await self._call_worker(serviceobj, name, *args)
  File "middlewared/main.py", line 997, in _call_worker
    job,
  File "middlewared/main.py", line 928, in run_in_proc
    return await self.run_in_executor(self.__procpool, method, *args, **kwargs)
  File "middlewared/main.py", line 913, in run_in_executor
    return await loop.run_in_executor(pool, functools.partial(method, *args, **kwargs))

Traceback above happens when calling:

{
'id': '7479a34d-1573-5942-3c90-d62a5eedf9fd', 
'method': 'jail.list_resource', 
'msg': 'method', 
'params': [
'PLUGIN', 
True
]
}

We need to figure out why this method is being called if it should not be.
If not why do we need iocage configure while listing plugins.

https://sentry.ixsystems.com/ixsystems/freenas-middleware/issues/12763/


Related issues

Copied from FreeNAS - Bug #45750: Fix traceback when listing pluginsDone

History

#1 Updated by Brandon Schneider about 2 years ago

  • Copied from Bug #45750: Fix traceback when listing plugins added

#2 Updated by Brandon Schneider about 2 years ago

  • Subject changed from Traceback when listing plugins to iocage pool needs to be activated before any plugin or jail operations can happen in UI

#3 Updated by Lola Yang about 2 years ago

  • Status changed from Unscreened to In Progress

#4 Updated by Lola Yang about 2 years ago

  • Status changed from In Progress to Ready for Testing
  • Needs Merging changed from Yes to No

#5 Updated by Dru Lavigne about 2 years ago

  • Subject changed from iocage pool needs to be activated before any plugin or jail operations can happen in UI to Alert if iocage pool is not activated before performing any plugin or jail operations in UI

#6 Updated by Timothy Moore II about 2 years ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

Testing with FreeNAS VM installed with FreeNAS-11.2-MASTER-201809200901:

Install FreeNAS and log in to new UI. Go to Plugins > Available, Plugins > Installed, and Jails pages. Verify there is a placeholder page in each location that prompts the user to create a pool before any options are available with jails/plugins. Follow link on prompt and create pool1. Go back to the previously tested screens: iocage automatically activated to this first pool and all options for plugins and jails are now available.

#7 Updated by Timothy Moore II about 2 years ago

  • Needs Doc changed from Yes to No

Docs PR [angulargui] https://github.com/freenas/freenas-docs/pull/362. No [master] branch PRs necessary.

#8 Updated by Dru Lavigne almost 2 years ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF