Project

General

Profile

Bug #47415

Fix traceback when trying to stop VMs on volume detach/export

Added by William Grzybowski almost 2 years ago. Updated almost 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
William Grzybowski
Category:
Middleware
Target version:
Seen in:
Severity:
Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

AttributeError: 'NoneType' object has no attribute 'lstrip'
  File "middlewared/main.py", line 155, in call_method
    result = await self.middleware.call_method(self, message)
  File "middlewared/main.py", line 1033, in call_method
    return await self._call(message['method'], serviceobj, methodobj, params, app=app, io_thread=False)
  File "middlewared/main.py", line 973, in _call
    return await methodobj(*args)
  File "middlewared/schema.py", line 664, in nf
    return await f(*args, **kwargs)
  File "plugins/vm.py", line 694, in stop_by_pool
    disk = disk.lstrip('/mnt/').split('/')[0]

https://sentry.ixsystems.com/ixsystems/freenas-middleware/issues/15570/

Acceptance Criteria
Have a VM running and detach the Volume/pool.

Associated revisions

Revision 962de601 (diff)
Added by William Grzybowski almost 2 years ago

fix(middlewared/vm): avoid exception if `path` does not exist While I'm here simplify logic/construct. Ticket: #47415

Revision f0ed6318 (diff)
Added by William Grzybowski almost 2 years ago

feat(gui): do not make vm.stop_by_pool fatal Ticket: #47415

Revision d198c67e (diff)
Added by William Grzybowski almost 2 years ago

fix(middlewared/vm): avoid exception if `path` does not exist While I'm here simplify logic/construct. Ticket: #47415

Revision 9ca7724d (diff)
Added by William Grzybowski almost 2 years ago

feat(gui): do not make vm.stop_by_pool fatal Ticket: #47415

History

#1 Updated by William Grzybowski almost 2 years ago

  • Description updated (diff)
  • Needs QA changed from No to Yes

#2 Updated by Dru Lavigne almost 2 years ago

  • Status changed from Unscreened to In Progress

#3 Updated by Bug Clerk almost 2 years ago

  • Status changed from In Progress to Ready for Testing

#4 Updated by Dru Lavigne almost 2 years ago

  • Subject changed from Traceback trying to stop VMs on volume detach/export to Fix traceback when trying to stop VMs on volume detach/export
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#5 Updated by Jeff Ervin almost 2 years ago

31949

Test Passed FreeNAS-11.2-MASTER-201809260853

Had VM's running, detached pool. No errors reported.

#6 Updated by Dru Lavigne almost 2 years ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF