Project

General

Profile

Bug #48031

Prevent calling fenced multiple times on TrueNAS HA systems

Added by Caleb St. John about 1 year ago. Updated 12 months ago.

Status:
Done
Priority:
No priority
Assignee:
Caleb St. John
Category:
Middleware
Target version:
Seen in:
TrueNAS - TrueNAS 11.1-U5.1
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

This only effects TrueNAS HA appliances. Diagnosing another problem unrelated, I discovered that calling fenced multiple times on the same system can cause the box to panic.

This is because once the process is daemonized, it will make a check

if (saved_key == disk.ourkey):
means that if the stamp that is queued to be placed on the disk matches the key that has already been placed on the disk, it will panic the box.

The simple solution here is to add logic to carp-state-change-hook.py to create a "lock" file that fenced will reference and make sure doesn't already exist before starting. The reason why it should be in carp-state-change-hook.py is that is the only place that calls fenced.


Related issues

Copied to FreeNAS - Bug #57375: Prevent calling fenced multiple times on TrueNAS HA systemsDone

History

#2 Updated by Caleb St. John about 1 year ago

  • Status changed from Unscreened to In Progress

#3 Updated by Caleb St. John about 1 year ago

  • Status changed from In Progress to Ready for Testing
  • Needs Merging changed from Yes to No

Test procedure.

1. ssh into active controller
2. type in "fenced" at the CLI
3. check /var/log/messages for verbiage like "Oct 30 14:38:33 tn02-b [fenced:121] fenced is already running. exiting"

#4 Updated by Dru Lavigne about 1 year ago

  • Subject changed from calling fenced multiple times can cause a panic to Prevent calling fenced multiple times

#5 Updated by Dru Lavigne about 1 year ago

  • Project changed from TrueNAS to FreeNAS
  • Category deleted (HA)
  • Target version changed from TrueNAS 11.1-U7 to TrueNAS 11.1-U6.2
  • Migration Needed deleted (No)
  • Hide from ChangeLog deleted (No)
  • Support Department Priority deleted (0)

#6 Updated by Dru Lavigne about 1 year ago

  • Subject changed from Prevent calling fenced multiple times to Prevent calling fenced multiple times on TrueNAS HA systems

#7 Updated by Dru Lavigne about 1 year ago

  • Copied to Bug #57375: Prevent calling fenced multiple times on TrueNAS HA systems added

#8 Updated by Dru Lavigne about 1 year ago

  • Category set to Middleware

#9 Updated by Bonnie Follweiler 12 months ago

43623

Test Passed in TrueNAS-11.1-U6.2-INTERNAL2

#10 Updated by Dru Lavigne 12 months ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF