Project

General

Profile

Bug #53604

Fix traceback on pool resilver priority update

Added by Bug Clerk over 1 year ago. Updated over 1 year ago.

Status:
Done
Priority:
No priority
Assignee:
Waqar Ahmed
Category:
Middleware
Target version:
Seen in:
Severity:
Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

[2018/10/21 17:01:35] (WARNING) application.call_method():189 - Exception while calling pool.resilver.update(*[{'enabled': False, 'begin': '18:00', 'end': '09:00', 'weekday': []}])
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 161, in call_method
    result = await self.middleware.call_method(self, message)
  File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 1043, in call_method
    return await self._call(message['method'], serviceobj, methodobj, params, app=app, io_thread=False)
  File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 983, in _call
    return await methodobj(*args)
  File "/usr/local/lib/python3.6/site-packages/middlewared/service.py", line 201, in update
    f'{self._config.namespace}.update', self, self.do_update, [data]
  File "/usr/local/lib/python3.6/site-packages/middlewared/main.py", line 983, in _call
    return await methodobj(*args)
  File "/usr/local/lib/python3.6/site-packages/middlewared/schema.py", line 664, in nf
    return await f(*args, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/middlewared/plugins/pool.py", line 147, in do_update
    if len(set(original_config.items()) ^ set(new_config.items())) > 0:
TypeError: unhashable type: 'list'
config    
{
'begin': datetime.time(18, 0), 
'enabled': False, 
'end': datetime.time(9, 0), 
'id': 1, 
'weekday': []
}
data    
{
'begin': '18:00', 
'enabled': False, 
'end': '09:00', 
'weekday': []
}
new_config    
{
'begin': datetime.time(18, 0), 
'enabled': False, 
'end': datetime.time(9, 0), 
'id': 1, 
'weekday': []
}
original_config    
{
'begin': datetime.time(18, 0), 
'enabled': False, 
'end': datetime.time(9, 0), 
'id': 1, 
'weekday': '7'
}

https://sentry.ixsystems.com/ixsystems/freenas-middleware/issues/17306/


Related issues

Copied from FreeNAS - Bug #53235: Fix traceback on pool resilver priority updateClosed
Copied to FreeNAS - Bug #53946: Fix traceback on pool resilver priority updateDone

History

#1 Updated by Bug Clerk over 1 year ago

  • Copied from Bug #53235: Fix traceback on pool resilver priority update added

#2 Updated by Bug Clerk over 1 year ago

  • Target version changed from Master - FreeNAS Nightlies to 11.2-RC2

#3 Updated by Bug Clerk over 1 year ago

  • Status changed from Unscreened to In Progress

#4 Updated by Bug Clerk over 1 year ago

  • Status changed from In Progress to Ready for Testing

#5 Updated by Bug Clerk over 1 year ago

  • Copied to Bug #53946: Fix traceback on pool resilver priority update added

#6 Updated by Dru Lavigne over 1 year ago

  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#7 Updated by Jeff Ervin over 1 year ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

Test Passed FreeNAS-11.2-INTERNAL31

Modified/saved Resilver priority (Begin Time, Days). Middleware log provided below.

[2018/10/30 19:18:24] (DEBUG) freenasOS.Configuration.TryGetNetworkFile():693 -TryGetNetworkFile(['http://update.ixsystems.com/FreeNAS/trains.txt', 'http://update-master.ixsystems.com/FreeNAS/trains.txt'])
[2018/10/30 19:18:24] (DEBUG) freenasOS.Configuration.TryGetNetworkFile():823 -TryGetNetworkFile(['http://update.ixsystems.com/FreeNAS/trains.txt', 'http://update-master.ixsystems.com/FreeNAS/trains.txt']): Read 456 bytes total
[2018/10/30 19:18:24] (DEBUG) freenasOS.Configuration.TryGetNetworkFile():693 -TryGetNetworkFile(['http://update-master.ixsystems.com/FreeNAS/FreeNAS-11.2-STABLE/LATEST'])
[2018/10/30 19:18:24] (DEBUG) freenasOS.Configuration.TryGetNetworkFile():823 -TryGetNetworkFile(['http://update-master.ixsystems.com/FreeNAS/FreeNAS-11.2-STABLE/LATEST']): Read 2239 bytes total
[2018/10/30 19:18:24] (DEBUG) freenasOS.Configuration.TryGetNetworkFile():693 -TryGetNetworkFile(['http://update-master.ixsystems.com/updates/ix_crl.pem'])
[2018/10/30 19:18:24] (DEBUG) freenasOS.Configuration.CheckFreeSpace():84 - CheckFreeSpace(path=/tmp/tmpmdssln25.pem, pool=None, required=1028)
[2018/10/30 19:18:24] (DEBUG) freenasOS.Configuration.TryGetNetworkFile():823 -TryGetNetworkFile(['http://update-master.ixsystems.com/updates/ix_crl.pem']): Read 1028 bytes total
[2018/10/30 19:18:24] (DEBUG) freenasOS.Configuration.TryGetNetworkFile():693 -TryGetNetworkFile(['http://update.ixsystems.com/FreeNAS/Validators/ValidateUpdate-pcBO6C.txt', 'http://update-master.ixsystems.com/FreeNAS/Validators/ValidateUpdate-pcBO6C.txt'])
[2018/10/30 19:18:25] (DEBUG) freenasOS.Configuration.CheckFreeSpace():84 - CheckFreeSpace(path=/tmp/tmpdyu6dhfo, pool=None, required=185)
[2018/10/30 19:18:25] (DEBUG) freenasOS.Configuration.TryGetNetworkFile():823 -TryGetNetworkFile(['http://update.ixsystems.com/FreeNAS/Validators/ValidateUpdate-pcBO6C.txt', 'http://update-master.ixsystems.com/FreeNAS/Validators/ValidateUpdate-pcBO6C.txt']): Read 185 bytes total
[2018/10/30 19:18:25] (DEBUG) freenasOS.Update.CheckForUpdates():868 - CheckForUpdate: diffs = {'Packages': [(<freenasOS.Package.Package object at 0x81df59fd0>, 'upgrade', <freenasOS.Package.Package object at 0x81dee1048>), (<freenasOS.Package.Package object at 0x81df59128>, 'upgrade', <freenasOS.Package.Package object at 0x81de635c0>), (<freenasOS.Package.Package object at 0x81df598d0>, 'upgrade', <freenasOS.Package.Package object at 0x821c6b208>), (<freenasOS.Package.Package object at 0x81df59588>, 'upgrade', <freenasOS.Package.Package object at 0x821c6bba8>), (<freenasOS.Package.Package object at 0x81df59860>, 'upgrade', <freenasOS.Package.Package object at 0x81e65cac8>)], 'Reboot': True, 'Sequence': ('642524ab404fbf01fa75de62429093a6', 'd2f5bbb81785fcff78abaf7e4a32bb6e')}
[2018/10/30 19:18:25] (DEBUG) freenasOS.Configuration.TryGetNetworkFile():693 -TryGetNetworkFile(['http://update.ixsystems.com/FreeNAS/FreeNAS-11.2-STABLE/ChangeLog.txt', 'http://update-master.ixsystems.com/FreeNAS/FreeNAS-11.2-STABLE/ChangeLog.txt'])
[2018/10/30 19:18:25] (DEBUG) freenasOS.Configuration.TryGetNetworkFile():823 -TryGetNetworkFile(['http://update.ixsystems.com/FreeNAS/FreeNAS-11.2-STABLE/ChangeLog.txt', 'http://update-master.ixsystems.com/FreeNAS/FreeNAS-11.2-STABLE/ChangeLog.txt']): Read 49433 bytes total
[2018/10/30 19:20:13] (WARNING) aiohttp.websocket._send_frame():533 - websocketconnection is closing.
[2018/10/30 19:27:15] (DEBUG) freenasOS.Configuration.TryGetNetworkFile():693 -TryGetNetworkFile(['http://update.ixsystems.com/FreeNAS/trains.txt', 'http://update-master.ixsystems.com/FreeNAS/trains.txt'])
[2018/10/30 19:27:15] (DEBUG) freenasOS.Configuration.TryGetNetworkFile():823 -TryGetNetworkFile(['http://update.ixsystems.com/FreeNAS/trains.txt', 'http://update-master.ixsystems.com/FreeNAS/trains.txt']): Read 456 bytes total
[2018/10/30 19:27:15] (DEBUG) freenasOS.Configuration.TryGetNetworkFile():693 -TryGetNetworkFile(['http://update-master.ixsystems.com/FreeNAS/FreeNAS-11.2-STABLE/LATEST'])
[2018/10/30 19:27:15] (DEBUG) freenasOS.Configuration.TryGetNetworkFile():823 -TryGetNetworkFile(['http://update-master.ixsystems.com/FreeNAS/FreeNAS-11.2-STABLE/LATEST']): Read 2239 bytes total
[2018/10/30 19:27:15] (DEBUG) freenasOS.Configuration.TryGetNetworkFile():693 -TryGetNetworkFile(['http://update-master.ixsystems.com/updates/ix_crl.pem'])
[2018/10/30 19:27:15] (DEBUG) freenasOS.Configuration.CheckFreeSpace():84 - CheckFreeSpace(path=/tmp/tmpc5zl3afq.pem, pool=None, required=1028)
[2018/10/30 19:27:15] (DEBUG) freenasOS.Configuration.TryGetNetworkFile():823 -TryGetNetworkFile(['http://update-master.ixsystems.com/updates/ix_crl.pem']): Read 1028 bytes total
[2018/10/30 19:27:15] (DEBUG) freenasOS.Configuration.TryGetNetworkFile():693 -TryGetNetworkFile(['http://update.ixsystems.com/FreeNAS/Validators/ValidateUpdate-pcBO6C.txt', 'http://update-master.ixsystems.com/FreeNAS/Validators/ValidateUpdate-pcBO6C.txt'])
[2018/10/30 19:27:15] (DEBUG) freenasOS.Configuration.CheckFreeSpace():84 - CheckFreeSpace(path=/tmp/tmps29ugoe3, pool=None, required=185)
[2018/10/30 19:27:15] (DEBUG) freenasOS.Configuration.TryGetNetworkFile():823 -TryGetNetworkFile(['http://update.ixsystems.com/FreeNAS/Validators/ValidateUpdate-pcBO6C.txt', 'http://update-master.ixsystems.com/FreeNAS/Validators/ValidateUpdate-pcBO6C.txt']): Read 185 bytes total
[2018/10/30 19:27:15] (DEBUG) freenasOS.Update.CheckForUpdates():868 - CheckForUpdate: diffs = {'Packages': [(<freenasOS.Package.Package object at 0x81e666828>, 'upgrade', <freenasOS.Package.Package object at 0x81def49b0>), (<freenasOS.Package.Package object at 0x81e666b00>, 'upgrade', <freenasOS.Package.Package object at 0x81deeff98>), (<freenasOS.Package.Package object at 0x81e666b38>, 'upgrade', <freenasOS.Package.Package object at 0x821d1d4a8>), (<freenasOS.Package.Package object at 0x81e666550>, 'upgrade', <freenasOS.Package.Package object at 0x81e6669e8>), (<freenasOS.Package.Package object at 0x81e666860>, 'upgrade', <freenasOS.Package.Package object at 0x81e666198>)], 'Reboot': True, 'Sequence': ('642524ab404fbf01fa75de62429093a6', 'd2f5bbb81785fcff78abaf7e4a32bb6e')}
[2018/10/30 19:27:15] (DEBUG) freenasOS.Configuration.TryGetNetworkFile():693 -TryGetNetworkFile(['http://update.ixsystems.com/FreeNAS/FreeNAS-11.2-STABLE/ChangeLog.txt', 'http://update-master.ixsystems.com/FreeNAS/FreeNAS-11.2-STABLE/ChangeLog.txt'])
[2018/10/30 19:27:16] (DEBUG) freenasOS.Configuration.TryGetNetworkFile():823 -TryGetNetworkFile(['http://update.ixsystems.com/FreeNAS/FreeNAS-11.2-STABLE/ChangeLog.txt', 'http://update-master.ixsystems.com/FreeNAS/FreeNAS-11.2-STABLE/ChangeLog.txt']): Read 49433 bytes total
[2018/10/30 19:36:27] (DEBUG) ServiceService._simplecmd():280 - Calling: restart(cron)
[2018/10/30 19:41:47] (WARNING) aiohttp.websocket._send_frame():533 - websocketconnection is closing.
[2018/10/30 19:42:05] (DEBUG) ServiceService._simplecmd():280 - Calling: restart(cron)
[root@jeff-freenas ~]#ead 1028 bytes total

#8 Updated by Dru Lavigne over 1 year ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF