Project

General

Profile

Bug #53665

Update rclone to 1.44 and add support for Microsoft OneDrive

Added by Albert Ulmer almost 3 years ago. Updated almost 3 years ago.

Status:
Done
Priority:
No priority
Assignee:
Vladimir Vinogradenko
Category:
OS
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

When trying to run a cloud sync pull task using the cloud credentials, users get an error message like this:

"2018/10/25 14:59:10 Failed to configure OneDrive: invalid character 'b' looking for beginning of value"

The same method works flawlessly for Dropbox, so I suspect that the outdated version of rclone might be at fault. Setting up the same process on the CLI using the latest version of rclone works, while the one included in FreeNAS does not.

Please update rclone to the latest version.


Related issues

Copied to FreeNAS - Bug #54072: Update rclone to 1.44 and add support for Microsoft OneDrive Done

History

#1 Updated by Dru Lavigne almost 3 years ago

  • Subject changed from Onedrive Cloud Sync doesn't work to Update rclone to 1.43
  • Category changed from Middleware to OS
  • Assignee changed from Release Council to Alexander Motin

RC1 uses version 1.42.

#2 Updated by Albert Ulmer almost 3 years ago

  • File debug-ul16s007-20181025131411.txz added
  • Private changed from No to Yes

#3 Updated by Alexander Motin almost 3 years ago

  • Assignee changed from Alexander Motin to Vladimir Vinogradenko

Vladimir, it seems like your area.

#4 Updated by Vladimir Vinogradenko almost 3 years ago

  • Status changed from Unscreened to Blocked
  • Reason for Blocked set to Waiting for feedback

Albert, please check this: https://redmine.ixsystems.com/issues/45479#note-4

Same applies for OneDrive: rclone needs token as JSON object, you're probably specifying just the token itself.

Please let us know if it was any help.

#5 Updated by Albert Ulmer almost 3 years ago

Vladimir Vinogradenko wrote:

Albert, please check this: https://redmine.ixsystems.com/issues/45479#note-4

Same applies for OneDrive: rclone needs token as JSON object, you're probably specifying just the token itself.

Please let us know if it was any help.

Thanks for the link, it does appear I was using the app password from Microsoft Graph, but this is where the Access Token instructions linked in the "?" help lead me. Anyway, I now pasted the JSON style access token into the GUI-field:

[snip] {"access_token":"EwCAA ..... yp*Ad","expiry":"2018-10-26T04:28:16.2733897+02:00"}
[snip]

Unfortunately, I still get an error, albeit a different one:

[snip]
'2018/10/26 03:33:07 Failed to create file system for "remote:": failed to get root: unauthenticated: Authentication failed'
[snip]

I verified this by doing the manual config procedure of rclone on the CLI, yielding the exact same result (no surprise):

[snip]
root@ul16s007[~]# rclone version
rclone v1.42
- os/arch: freebsd/amd64
- go version: go1.10.1
root@ul16s007[~]# rclone about ula-onedrive:
2018/10/26 03:42:24 Failed to create file system for "ula-onedrive:": failed to get root: unauthenticated: Authentication failed
[snip]

Same happens using this old 1.42 version on my windows machine. If I upgrade to 1.44, however, it works perfectly. Note that it also asks some different and additional questions when setting up rclone in 1.44, so I guess Microsoft changed something that makes rclone 1.42 entirely obsolete for OneDrive:

[snip]
C:\Users\Albert>rclone version
rclone v1.44
- os/arch: windows/amd64
- go version: go1.11

C:\Users\Albert>rclone about ula-onedrive:
Total: 1.029T
Used: 365.288G
Free: 688.712G
Trashed: 59.243M
[snip]

So to cut a long story short, rclone must be updated in order for Onedrive to work in the Cloud Credentials/SyncTasks.

#6 Updated by Vladimir Vinogradenko almost 3 years ago

Albert, thank you for this information, we'll update rclone version.

Also do you need to specify drive_id and drive_type in order for everything to work?

#7 Updated by Bug Clerk almost 3 years ago

  • Status changed from Blocked to In Progress

#8 Updated by Bug Clerk almost 3 years ago

  • Status changed from In Progress to Ready for Testing

11.2-stable PR: https://github.com/freenas/ports/pull/151 (no master needed)

#9 Updated by Bug Clerk almost 3 years ago

  • Target version changed from Backlog to 11.2-RC2

#10 Updated by Vladimir Vinogradenko almost 3 years ago

  • Status changed from Ready for Testing to In Progress

#11 Updated by Bug Clerk almost 3 years ago

  • Status changed from In Progress to Ready for Testing

#12 Updated by Bug Clerk almost 3 years ago

  • Target version changed from 11.2-RC2 to 11.3

#13 Updated by Bug Clerk almost 3 years ago

  • Copied to Bug #54072: Update rclone to 1.44 and add support for Microsoft OneDrive added

#14 Updated by Bug Clerk almost 3 years ago

  • Status changed from Ready for Testing to In Progress

#15 Updated by Vladimir Vinogradenko almost 3 years ago

  • Status changed from In Progress to Ready for Testing

#16 Updated by Dru Lavigne almost 3 years ago

  • File deleted (debug-ul16s007-20181025131411.txz)

#17 Updated by Dru Lavigne almost 3 years ago

  • Subject changed from Update rclone to 1.43 to Support Microsoft OneDrive in rclone
  • Private changed from Yes to No
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#18 Updated by Dru Lavigne almost 3 years ago

  • Subject changed from Support Microsoft OneDrive in rclone to Update rclone to 1.43 and add support for Microsoft OneDrive
  • Status changed from Ready for Testing to In Progress
  • Needs Doc changed from No to Yes
  • Needs Merging changed from No to Yes

#20 Updated by Albert Ulmer almost 3 years ago

Vladimir Vinogradenko wrote:

Albert, thank you for this information, we'll update rclone version.

Also do you need to specify drive_id and drive_type in order for everything to work?

Yes, it appears so. The rclone config process generates them automatically to be futureproof with Microsoft's new Graph API, which potentially allows access to many more services like Sharepoint storage etc.

#22 Updated by Bug Clerk almost 3 years ago

  • Status changed from Ready for Testing to In Progress

#23 Updated by Bug Clerk almost 3 years ago

  • Status changed from In Progress to Ready for Testing

#24 Updated by Dru Lavigne almost 3 years ago

  • Subject changed from Update rclone to 1.43 and add support for Microsoft OneDrive to Update rclone to 1.44 and add support for Microsoft OneDrive
  • Needs Merging changed from Yes to No

#25 Updated by Dru Lavigne almost 3 years ago

  • Status changed from Ready for Testing to Done
  • Target version changed from 11.3 to Master - FreeNAS Nightlies
  • Reason for Blocked deleted (Waiting for feedback)
  • Needs QA changed from Yes to No
  • Needs Doc changed from Yes to No

Also available in: Atom PDF