Project

General

Profile

Bug #53817

Fix Discovery Auth Group dropdown menu in new UI

Added by Thomas Gallen almost 2 years ago. Updated almost 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Lola Yang
Category:
GUI (new)
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

I've been attempting to set up CHAP or Mutual CHAP authentication with iSCSI and have run across what I believe to be a UI form bug, and some confusing form validation errors when attempting to add a Portal. After adding an Authorized Access entry with either 1 or 2 credentials, I then go back to Portal and attempt to add a new Portal entry. Selecting either "CHAP" or "Mutual CHAP" results in an empty Discovery Auth Group drop down. Clicking Save (just to see the error message) then results in an erroneous error message suggesting that "Chap" or "mutual_chap" are invalid choices, when they clearly are not.

I can work around this by hitting the back-end API directly with valid values for the time being. Let me know if you need more information or debug logs.

Thanks,
Thomas

Fix-Discovery-Auth-Methods.patch (1.3 KB) Fix-Discovery-Auth-Methods.patch Replaces invalid Discovery Auth Method values (against webui HEAD). Thomas Gallen, 10/25/2018 01:14 PM
Screen Shot 2018-11-01 at 2.55.00 PM.png (59.6 KB) Screen Shot 2018-11-01 at 2.55.00 PM.png Jeff Ervin, 11/01/2018 12:01 PM
Screen Shot 2018-11-01 at 2.54.39 PM.png (53.9 KB) Screen Shot 2018-11-01 at 2.54.39 PM.png Jeff Ervin, 11/01/2018 12:01 PM
Screen Shot 2018-11-01 at 2.55.55 PM.png (53.6 KB) Screen Shot 2018-11-01 at 2.55.55 PM.png Jeff Ervin, 11/01/2018 12:01 PM
38400
38403
38412

Related issues

Has duplicate FreeNAS - Bug #57087: Can't Select Discovery Auth Groups in iSCSI Portal using new UIClosed

History

#1 Updated by Dru Lavigne almost 2 years ago

  • Assignee changed from Release Council to Erin Clark
  • Target version changed from Backlog to 11.2-RC2

#3 Updated by Thomas Gallen almost 2 years ago

I've taken a moment to familiarizing myself with how the new FreeNAS interface is interacting with the back-end API, and it would seem that the current Portal forms, both create and edit, are submitting the following values for the Discovery Auth Method field:

"None" > "None"
"CHAP" > "Chap"
"Mutual CHAP" > "mutual_chap"

As far as I'm aware, the documentation states that it should be producing the following values:

"None" > "None"
"CHAP" > "CHAP"
"Mutual CHAP" > "CHAP Mutual"

I've tested these values against one of the FreeNAS-11.2-RC1 machines I have available and this seems to fix the error messages referencing the Discovery Auth Method field. I also noticed that these values appear to be case sensitive.

This doesn't do anything for pre-populating/populating the Discovery Auth Group drop-down, however.

#4 Updated by Thomas Gallen almost 2 years ago

The issue with the Discovery Auth Method drop-down was just the constants in the files below. See also attached.

src/app/pages/sharing/iscsi/portal/portal-add/portal-add.component.ts
src/app/pages/sharing/iscsi/portal/portal-edit/portal-edit.component.ts

#5 Updated by Thomas Gallen almost 2 years ago

The issue with the Discovery Auth Group field is that the typescript to populate the field has yet to be written. I'm off the clock in a few minutes so I won't be able to finish a patch for it today, but it should be trivial to adapt the code already in use for the Target forms to grab a list of Authorized Access group IDs.

src/app/pages/sharing/iscsi/target/target-form/target-form.component.ts

#6 Updated by Lola Yang almost 2 years ago

  • Status changed from Unscreened to Screened
  • Assignee changed from Erin Clark to Lola Yang

#7 Updated by Lola Yang almost 2 years ago

  • Status changed from Screened to In Progress

#8 Updated by Erin Clark almost 2 years ago

  • Status changed from In Progress to Ready for Testing

#9 Updated by Thomas Gallen almost 2 years ago

Good evening,

I can confirm that the drop-down boxes for both Discovery Auth Method and Discovery Auth Group are now functioning as expected. Thanks for fixing this so quickly! I really appreciate it as I've been wanting to demonstrate the iSCSI functionality for the past few weeks.

Thanks again,
Thomas

#10 Updated by Dru Lavigne almost 2 years ago

  • Subject changed from Sharing > iSCSI > Portal > Discovery Auth Group dropdown doesn't populate. to Fix Discovery Auth Group dropdown menu in new UI
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#11 Updated by Jeff Ervin almost 2 years ago

38400
38403
38412

Test Passed FreeNAS-11.2-INTERNAL32

Used the following (with modifications - see screenshots). Received no errors when saving.

Create a zvol for your iscsi share - at least 30 GiB
Go to Sharing -> ISCSI -> Portals and name the comment: iscsi test. Leave Discovery Auth Method: and Discovery Auth Group: as None. Select the IP address of the TrueNAS testing system and the port should be 3260
Go to Sharing -> ISCSI -> Initiators and leave the values at the default and Save
Skip Sharing -> ISCSI -> Authorized Address
Go to Sharing -> ISCSI -> Targets: Add a Target. Name Target Name and Target Access d1. Choose Portal Group ID: and Initiator Group ID: from the pop up list. Click Save
Go to Services -> ISCSI -> Extents and click Add Extent. The name is d1. The Extent Type is Device and for the Device choose the zvol you created, check Disable block size reporting, and be sure the block size is 512. Type "iscsi test" in the comment field and Click the Save button.
Go to Sharing -> ISCSI -> Associated Targets and click Add Target/Extent. Select d1 from the target pop up list, make the LUN ID 100, and choose d1 for the Extent. Click the Save button
Go to Services - ISCSI and turn it on and click Start on Boot
Write down the IP address from the Sharing -> ISCSI -> Portals

#12 Updated by Dru Lavigne almost 2 years ago

  • Status changed from Passed Testing to Done

#13 Updated by Dru Lavigne almost 2 years ago

  • Has duplicate Bug #57087: Can't Select Discovery Auth Groups in iSCSI Portal using new UI added

Also available in: Atom PDF