Project

General

Profile

Bug #54063

Properly migrate system dataset on export

Added by Waqar Ahmed 10 months ago. Updated 5 months ago.

Status:
Done
Priority:
No priority
Assignee:
William Grzybowski
Category:
Middleware
Target version:
Severity:
Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

If a volume has systemdatasets in it, we are unable to detach it successfully specifying destroy disks = True. It results in `Device Busy` traceback which comes from the delete function in zfs plugin. I suspect that the systemdatasets haven't moved to another suitable place ( vol or freenas-boot ) and we don't set force to True when using delete funciton.

Risk
We risk breaking creation/deletion of volumes

Acceptance Criteria
A volume should be made and it should be ensured that it contains the system datasets by using `zfs list` command which will show the system datasets and in which volume they are. Once it has been confirmed that they exist in that volume, that volume should be detached while setting mark disks as new to True. If it succeeds, we can mark it as accepted. ( William please update as necessary )

Associated revisions

Revision d2050563 (diff)
Added by William Grzybowski 10 months ago

fix(middlewared/pool): properly migrate system dataset on export

Ticket: #54063

Revision 15d1865c (diff)
Added by William Grzybowski 10 months ago

fix(middlewared/pool): properly migrate system dataset on export

Ticket: #54063

Revision c9b4a185 (diff)
Added by William Grzybowski 10 months ago

fix(middlewared/pool): properly migrate system dataset on export

Ticket: #54063

Revision 26b3217b (diff)
Added by William Grzybowski 10 months ago

fix(middlewared/pool): properly migrate system dataset on export

Ticket: #54063

Revision dd5666bb (diff)
Added by William Grzybowski 10 months ago

fix(middlewared/pool): properly migrate system dataset on export

Ticket: #54063

History

#1 Updated by William Grzybowski 10 months ago

  • Status changed from Unscreened to Not Started
  • Severity changed from New to Medium

#2 Updated by Bug Clerk 10 months ago

  • Status changed from Not Started to In Progress

#3 Updated by Bug Clerk 10 months ago

  • Status changed from In Progress to Ready for Testing

#4 Updated by Dru Lavigne 10 months ago

  • Subject changed from Unable to detach a volume specifying destroy=True when it has sytemdatasets to Properly migrate system dataset on export
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#5 Updated by Dru Lavigne 7 months ago

  • Target version changed from 11.3 to 11.3-BETA1

#9 Avatar?id=55038&size=24x24 Updated by Zackary Welch 5 months ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

Confirmed fixed in 11.3-BETA1.

#10 Updated by Dru Lavigne 5 months ago

  • Status changed from Passed Testing to Done

#11 Updated by Dru Lavigne 5 months ago

  • Target version changed from 11.3-BETA1 to 11.3-ALPHA1

Also available in: Atom PDF