Properly move system dataset at bootup
When we create a new volume from legacy UI, syslog-ng stops running as a service. This causes different crashes in the system internally like ftp service fails to start because of syslog-ng not running. Moving on, once the volume has been created, we are unable to detach it at all with the following error
Exception Value: [EFAULT] Command '('mount', '-t', 'zfs', 'vol1/.system', '/var/db/system')' returned non-zero exit status 1.
( All of this has been done in legacy UI )
We risk breaking other different services in the system which use the system datasets as well as storage functionalities completely
It should be ensured that syslog-ng doesn't stop running after a volume has been created and we are able to detach that volume. Plus we should be checking if we are able to start ftp after creating a volume. ( William please update accordingly if needed )
fix(middlewared/sysdataset): properly move sysds around and on first boot
- Status changed from Ready for Testing to Passed Testing
- Needs QA changed from Yes to No
I was able to create a volume and confirm syslog-ng is still running. I also saw no exception when detaching the volume. I was also able to start ftpd after volume creation. The pid of syslog-ng changed, but that seems okay, since it got running again.
Tested in both the old and new UI.