Project

General

Profile

Bug #55980

Prevent setting record or block sizes below 4K and warn when changing record size

Added by Alexander Motin about 1 year ago. Updated 12 months ago.

Status:
Done
Priority:
No priority
Assignee:
Vaibhav Chauhan
Category:
GUI (new)
Target version:
Seen in:
Severity:
Low Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

There are multiple cases when users shoot their foot by setting dataset record or zvol block sizes too small, that negatively impact performance due to huge CPU processing overhead, pool storage efficiency, but also can get system out of memory due to inability of present (11.1 and above) ARC to efficiently store blocks less then 4KB.

I think we should completely forbid record/blocks less then 4KB there (remove from the lists), and warn users about possible negative effects for sequential I/O performance and space efficiency if they are setting value less then the default one we are calculating now for zvols, based on pool topology.


Related issues

Related to FreeNAS - Bug #60777: Fix mat-option hover and focus having same styles in new UIDone
Related to FreeNAS - Bug #62028: Set correct values for quotas in edit mode of new UIDone

History

#2 Updated by Erin Clark about 1 year ago

  • Assignee changed from Erin Clark to Vaibhav Chauhan

#3 Updated by Vaibhav Chauhan about 1 year ago

#4 Updated by Vaibhav Chauhan about 1 year ago

  • Status changed from Unscreened to In Progress

#6 Updated by Erin Clark 12 months ago

  • Target version changed from 11.2-U2 to 11.2-RELEASE

#7 Updated by Vaibhav Chauhan 12 months ago

#8 Updated by Erin Clark 12 months ago

  • Status changed from In Progress to Ready for Testing

#9 Updated by Dru Lavigne 12 months ago

  • Subject changed from Protection against dataset/zvol record/block size being set too low to Prevent setting record or block sizes below 4K and warn when changing record size
  • Needs Merging changed from Yes to No

#13 Updated by Timothy Moore II 12 months ago

42318
42327

Testing with FreeNAS Mini updated to INTERNAL53:

Go to Storage/Pools and add a new Zvol to an existing pool. Click "ADVANCED MODE" and verify the "Block size" can be no less than "4K" (zvol-block-size.png). Confirm changing "Block size" to smaller than 4K is not an option for an existing Zvol.

Go to Storage/Pools and add a new dataset to an existing pool. Click "ADVANCED MODE" and review the "Record Size" option. Options exist to set the record size to "512", "1K", and "2K" (dataset-record-size.png). Editing an existing dataset also has options to set the record size to less than 4K.

#14 Updated by Jeff Ervin 12 months ago

42336

Test Passed FreeNAS-11.2-INTERNAL53

#15 Updated by Jeff Ervin 12 months ago

  • Status changed from Passed Testing to Failed Testing

Failed Test FreeNAS-11.2-INTERNAL53

#16 Updated by Jeff Ervin 12 months ago

  • Needs QA changed from No to Yes

#17 Updated by Alexander Motin 12 months ago

While there, in phrase "Other sizes could reduce sequential I/O performance space efficiency" I'd write "Lower sizes ...", since bigger sises should actually improve those two things, hurting instead random I/O performance.

#18 Updated by Warren Block 12 months ago

I'd suggest "smaller sizes".

#19 Updated by Dru Lavigne 12 months ago

  • Status changed from Failed Testing to Ready for Testing

#20 Updated by Jeff Ervin 12 months ago

42705
42714
42723
42732

Test Passed FreeNAS-11.2-INTERNAL57

Note: Spoke to developer, requested I add a ticket to fix the issue of highlighting more than one option in the drop down field (anything under 4k is highlighted with current acceptable choice, but nothing can be selected/saved/updated below 4k).

#21 Updated by Jeff Ervin 12 months ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

#22 Updated by Jeff Ervin 12 months ago

  • Related to Bug #60777: Fix mat-option hover and focus having same styles in new UI added

#23 Updated by Timothy Moore II 12 months ago

  • Needs Doc changed from Yes to No

#24 Updated by Dru Lavigne 12 months ago

  • Status changed from Passed Testing to Done

#25 Updated by Vaibhav Chauhan 11 months ago

  • Related to Bug #62028: Set correct values for quotas in edit mode of new UI added

Also available in: Atom PDF