Project

General

Profile

Bug #55995

Remove unused get_disk function that slowed Wizard on systems with Fibre Channel cards

Added by Jeff Ervin about 1 year ago. Updated 12 months ago.

Status:
Done
Priority:
No priority
Assignee:
Caleb St. John
Category:
Middleware
Target version:
Seen in:
TrueNAS - TrueNAS 11.1-U5
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Breakdown of each section of wizard times as follows:

Wizard Access: 1:00.29
Language/Time Zone: 2:43.17
Active Directory: 2:40.97
Share Setup: 1:59.52
Email: 2:44.69
Share Creation: 3:57.79
TOTAL=12:08

Volume creation done previously. Network snapshot created for verification of this speed not being network influenced.


Related issues

Copied to FreeNAS - Bug #57357: Remove unused get_disk function that slowed Wizard on systems with Fibre Channel cardsDone

History

#2 Updated by Bonnie Follweiler about 1 year ago

We updated to 11.1-u6.1 and the Wizard is still taking too long (about the same amount of time as in U5.1

#3 Updated by Dru Lavigne about 1 year ago

  • Assignee changed from Release Council to Caleb St. John

#5 Updated by Caleb St. John about 1 year ago

  • Status changed from Screened to Ready for Testing

This particular issue only effects TrueNAS customers with FiberChannel cards installed.

This function "get_disks" is no longer needed in the code base so it can be removed entirely. Very briefly testing this on tn11.lab allowed the wizard to pull up the screen considerably quicker.

The wizard function still takes awhile, but it's faster to the point where it's usable.

master PR: https://github.com/iXsystems/truenas/pull/205
11.1 PR: https://github.com/iXsystems/truenas/pull/206

Test case:

1. start the Wizard and make sure it gets past the initial screen.
(note, the wizard won't be smoking fast but it will be faster to the point it's usable)

#6 Updated by Dru Lavigne about 1 year ago

  • Subject changed from Wizard setup took 12:08 minutes from start to finish on M50 to Remove unused get_disk function that slowed Wizard on systems with Fibre Channel cards
  • Target version changed from Backlog to TrueNAS 11.1-U6.2
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#7 Updated by Dru Lavigne 12 months ago

  • Copied to Bug #57357: Remove unused get_disk function that slowed Wizard on systems with Fibre Channel cards added

#8 Updated by Bonnie Follweiler 12 months ago

  • Status changed from Ready for Testing to Passed Testing
  • Needs QA changed from Yes to No

#10 Updated by Dru Lavigne 12 months ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF