Project

General

Profile

Bug #56412

Fix labels and tooltips for OneDrive fields in new UI

Added by Samantha Bonham over 1 year ago. Updated over 1 year ago.

Status:
Done
Priority:
Blocks Until Resolved
Assignee:
Lola Yang
Category:
GUI (new)
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

The field "Drive Type" was added, but this is misleading and suggests actual drive types (SATA, SSDs, etc). After doing some digging, it looks like Drive Type: "Personal", "Business", or "Document_library" are different types of Microsoft accounts. My suggestion is to change "Drive Type" to "Account Type". We will wait for the fix before adding the tooltips.

root@freenas:~ # midclt call cloudsync.providers | python -m json.tool
...
    {
        "name": "ONEDRIVE",
        "title": "Microsoft OneDrive",
        "credentials_schema": [
            {
                "property": "token",
                "schema": {
                    "title": "Access Token",
                    "_required_": true,
                    "type": "string" 
                }
            },
            {
                "property": "drive_type",
                "schema": {
                    "title": "Drive Type",
                    "_required_": true,
                    "type": "string",
                    "enum": [
                        "PERSONAL",
                        "BUSINESS",
                        "DOCUMENT_LIBRARY" 
                    ]
                }
            },
            {
                "property": "drive_id",
                "schema": {
                    "title": "Drive ID",
                    "_required_": true,
                    "type": "string" 
                }
            }
        ],
        "buckets": false,
        "task_schema": []
    },
...

However only Access Token field is rendered

https://redmine.ixsystems.com/attachments/download/38607/Screen%20Shot%202018-11-02%20at%201.59.29%20PM.png


Related issues

Related to FreeNAS - Bug #56709: Use middleware method 'cloudsync.providers' to get providersClosed
Copied from FreeNAS - Bug #55881: Add fields for Microsoft OneDrive cloud credentials to new UIDone

History

#1 Updated by Samantha Bonham over 1 year ago

  • Copied from Bug #55881: Add fields for Microsoft OneDrive cloud credentials to new UI added

#2 Updated by William Grzybowski over 1 year ago

  • Category changed from GUI (new) to Middleware
  • Assignee changed from William Grzybowski to Vladimir Vinogradenko

#3 Updated by Dru Lavigne over 1 year ago

  • Seen in changed from 11.2-U2 to 11.2-RC2

#4 Updated by Dru Lavigne over 1 year ago

  • Target version set to 11.2-RC2

#5 Updated by Samantha Bonham over 1 year ago

Hi Vladimir. I talked to Tim and we decided "Drive Account Type" would be a better name for that field.

#6 Updated by William Grzybowski over 1 year ago

  • Category changed from Middleware to GUI (new)
  • Assignee changed from Vladimir Vinogradenko to Erin Clark

Erin, Valdimir told me new UI is not using `cloudsync.providers` so its a change needed directly in new UI.

#7 Updated by Erin Clark over 1 year ago

  • Assignee changed from Erin Clark to Lola Yang

#8 Updated by Lola Yang over 1 year ago

  • Status changed from Unscreened to In Progress
  • Needs Merging changed from No to Yes

#9 Updated by Erin Clark over 1 year ago

  • Status changed from In Progress to Ready for Testing

#10 Updated by Erin Clark over 1 year ago

The providers change is a big change so we will sort it out later, see this ticket https://redmine.ixsystems.com/issues/56709

#11 Updated by Erin Clark over 1 year ago

  • Related to Bug #56709: Use middleware method 'cloudsync.providers' to get providers added

#12 Updated by Erin Clark over 1 year ago

  • Subject changed from Add fields for Microsoft OneDrive cloud credentials to new UI to The field "Drive Type" should be labeled "Drive Account Type"

#13 Updated by Samantha Bonham over 1 year ago

#14 Updated by Dru Lavigne over 1 year ago

  • Subject changed from The field "Drive Type" should be labeled "Drive Account Type" to Fix labels and tooltips for OneDrive fields in new UI
  • Needs Merging changed from Yes to No

#15 Updated by Dru Lavigne over 1 year ago

  • Needs Doc changed from Yes to No

#17 Updated by Dru Lavigne over 1 year ago

  • Status changed from Passed Testing to Done

Also available in: Atom PDF