Project

General

Profile

Bug #56742

When removing directories from a package, sort them in reverse

Added by Sean Fagan almost 3 years ago. Updated over 2 years ago.

Status:
Done
Priority:
No priority
Assignee:
Sean Fagan
Category:
OS
Severity:
Medium
Reason for Closing:
Reason for Blocked:
Needs QA:
No
Needs Doc:
No
Needs Merging:
No
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Discussed in ryver today. Directory removals hadn't happened much, so they never got tested very well. In this case, we removed the freenasUI/documentation directory -- but that failed due to it not being empty, since freenasUI/documentation/__pycache__ still existed. That was in the pkgdb, however, but the list of directories to remove wasn't being sorted in reverse order.


Related issues

Related to FreeNAS - Umbrella #54909: Unhook Guide from build system and link to online versionDone

Associated revisions

Revision 4745dc67 (diff)
Added by Sean Fagan almost 3 years ago

When removing directories from a package, sort them in reverse order so the parents come after the children. This allows the directories to be removed. Ticket: #56742

History

#1 Updated by Sean Fagan almost 3 years ago

  • Status changed from Screened to In Progress

https://github.com/freenas/freenas-pkgtools/pull/14

Asked William to review, other people can as well.

#2 Updated by Dru Lavigne almost 3 years ago

  • Subject changed from Updates not removing obsoleted directories to When removing directories from a package, sort them in reverse
  • Status changed from In Progress to Ready for Testing
  • Needs Doc changed from Yes to No
  • Needs Merging changed from Yes to No

#3 Updated by Dru Lavigne almost 3 years ago

  • Related to Umbrella #54909: Unhook Guide from build system and link to online version added

#4 Updated by Dru Lavigne over 2 years ago

  • Status changed from Ready for Testing to Done
  • Needs QA changed from Yes to No

Also available in: Atom PDF