Project

General

Profile

Bug #5839

Need to break Windows and Mac sharing types apart

Added by Jordan Hubbard over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Nice to have
Assignee:
Josh Paetzel
Category:
-
Target version:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

Looks like we were wrong when we decided that "Windows and Mac" were the same as far as ACLs are concerned. In truth, it appears that Macs are much happier with Unix sharing permissions.

Proposal: Break existing sharing type drop-downs into three categories:

1. Unix
2. Windows
3. Mac

Make "Mac == Unix" behind the scenes, but only behind the scenes for now. There may be a later time when we support Open Directory and find that in that scenario, Mac + OpenDirectory = ACLs (e.g. not "Unix"), but if we make a separate category (and tag datasets appropriately) for "Mac", we can do that seamlessly without having to change the documentation.

macacl.png (26.5 KB) macacl.png Josh Paetzel, 08/29/2014 11:16 AM
1176

Related issues

Related to FreeNAS - Bug #5825: AFP: unable to create folders after upgrade to 9.2.1.6Resolved2014-08-11

Associated revisions

Revision f38bdb10 (diff)
Added by Josh Paetzel about 6 years ago

Change permission radio buttons so the mac choice is lumped in with unix. Ticket: #5839

Revision 8f1b19e5 (diff)
Added by Josh Paetzel about 6 years ago

Change permission radio buttons so the mac choice is lumped in with unix. Ticket: #5839 (cherry picked from commit f38bdb100bd61a47539190fd6c41f9a40b22a13d)

Revision 062a2777 (diff)
Added by Josh Paetzel about 6 years ago

Give Mac it's own radio button for permissions. This is identical to unix at this point, other than we write out a metadata file so we can keep the radio button what it was set to. (Without it's own metadata file it would never persist as mac, it would reset to unix) Also the mac metadata file gets vetoed in samba/netatalk, but since macs can speak NFS and there's no facility to veto files over this protocol....room for footshooting abounds. In the future we should switch this to be a custom dataset property perhaps, and not use metadata files at all. This migration for this would involve having code that looked for metadata files and created dataset properties, then deleted the metadata file. I suspect due to code differentiation this won't be a straight merge to 9.2.1-BRANCH Ticket: #5839

Revision 248cc894 (diff)
Added by Josh Paetzel about 6 years ago

Fix bug with setting permission type to mac. Ticket: #5839

History

#1 Updated by John Hixson over 6 years ago

  • Status changed from Unscreened to Screened

#2 Updated by Jordan Hubbard over 6 years ago

  • Target version changed from 9.3-M3 to 9.3-M2

#3 Updated by Jordan Hubbard over 6 years ago

  • Related to Bug #5825: AFP: unable to create folders after upgrade to 9.2.1.6 added

#4 Updated by Jordan Hubbard about 6 years ago

  • Target version changed from 9.3-M2 to 9.3-M3

#5 Updated by John Hixson about 6 years ago

  • Status changed from Screened to Resolved

Looks like this is already the case. Mac shares do not get initialized with ACL's.

#6 Updated by Josh Paetzel about 6 years ago

  • File macacl.png macacl.png added
  • Status changed from Resolved to Unscreened
  • Target version changed from 9.3-M3 to 9.2.1.8-RELEASE
1176

This is not resolved. Screenshot attached. See me if you have questions.

If you click the radio button that says windows/mac you get ACLS. Those don't work with AFP.

#7 Updated by John Hixson about 6 years ago

  • Status changed from Unscreened to Screened

#8 Updated by Josh Paetzel about 6 years ago

  • Status changed from Screened to Fix In Progress
  • Assignee changed from John Hixson to Josh Paetzel

I'm going to do the easy thing here and just change the labels of the radio buttons...otherwise we need to do a bunch of work to add metadata files to keep the correct radio button selected, which doesn't do anything.

#9 Updated by Josh Paetzel about 6 years ago

  • Status changed from Fix In Progress to Resolved

#10 Updated by Josh Paetzel about 6 years ago

  • Status changed from Resolved to Fix In Progress

Easy button unpressed. Committed a change that will give mac it's own radio button.

Will have to manually merge it to 9.2.1-BRANCH (hopefully tomorrow)

#11 Updated by Dru Lavigne about 6 years ago

Is it correct that the Mode is greyed out when Mac is selected?

#12 Updated by Josh Paetzel about 6 years ago

Nooooo. let me look at what I did wrong there.

#13 Updated by Josh Paetzel about 6 years ago

  • Status changed from Fix In Progress to Resolved

Dru:

Found the bug and fixed it.

#14 Updated by Dru Lavigne about 6 years ago

  • Status changed from Resolved to Unscreened

Was this also fixed for M3? It's still does not grey out in M3-adcae64.

#15 Updated by Josh Paetzel about 6 years ago

  • Status changed from Unscreened to Resolved

The unix permissions checkboxes should work when you click the Mac radio button.

#16 Updated by Dru Lavigne about 6 years ago

  • Status changed from Resolved to Closed

Verified in 9.2.1.8-RELEASE.

Also available in: Atom PDF