Project

General

Profile

Bug #58398

Browser issues in 11.2-RC2

Added by Stilez y almost 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
No priority
Assignee:
Damian Szidiropulosz
Category:
GUI (new)
Target version:
Seen in:
Severity:
New
Reason for Closing:
Reason for Blocked:
Needs QA:
Yes
Needs Doc:
Yes
Needs Merging:
Yes
Needs Automation:
No
Support Suite Ticket:
n/a
Hardware Configuration:
ChangeLog Required:
No

Description

I just upgraded from 11.1 (via legacy GUI) to 11.2. I use some less common browsers, but so will some other people.

Of the browsers I use (which all worked with 11.1/legacy), after reboot:

  • Windows 8.1 + default browser (IE 11) sits on a background graphic and won't do anything else at all.
  • Windows 8.1 + Pale Moon did the same as IE11, but the image fades in and out slightly, every few seconds.
  • Windows 8.1 + Vivaldi (a Chrome based browser) loads and works, but graphs are mishandled.

See attached screenshots.

gui-win8.1-IE-11-and-Pale-Moon.png (33.2 KB) gui-win8.1-IE-11-and-Pale-Moon.png GUI after upgrade (IE11 and Pale Moon) Stilez y, 11/18/2018 04:59 PM
gui-win8.1-vivaldi.png (157 KB) gui-win8.1-vivaldi.png GUI after upgrade (Vivaldi) Stilez y, 11/18/2018 04:59 PM
FN_IE11.jpg (74.7 KB) FN_IE11.jpg Damian Szidiropulosz, 01/15/2019 06:59 AM
41307
41316
48844

Associated revisions

Revision 30414d3e (diff)
Added by Erin Clark almost 3 years ago

Make polyfill generation work with npm Ticket: #58398

History

#1 Updated by Dru Lavigne almost 3 years ago

  • Assignee changed from Release Council to Anonymous
  • Target version changed from Backlog to 11.2-RELEASE

#3 Updated by Anonymous almost 3 years ago

  • Assignee changed from Anonymous to Damian Szidiropulosz

#4 Updated by Anonymous almost 3 years ago Private

what are your thoughts on these, Damian?

#5 Updated by Dru Lavigne almost 3 years ago

  • Target version changed from 11.2-RELEASE to 11.2-U2

#6 Updated by Damian Szidiropulosz almost 3 years ago

  • Status changed from Unscreened to Screened

The issue where the UI can't get past the load screen is probably due to some errors halting the process. These errors are usually visible from the browser JS console. Could you provide some screenshots of the JS console in the Windows browsers while that's happening?

#7 Updated by Stilez y almost 3 years ago

Spot on - good call, Damian. Both IE11 and Pale Moon agree on the issue, which is a syntax error in main.57ebfd2da123881a1a70.bundle.js at column 548077 or 548078, where the code tries to use a reserved word "class" (the file has been "de-beautified" and is a single huge line of text).

Code snippet:

...

let i={Queue:0,Uploading:1,Done:2,Cancelled:3};i[i.Queue]="Queue",i[i.Uploading]="Uploading",i[i.Done]="Done",
i[i.Cancelled]="Cancelled";>>>>>>class<<<<<< r{}},"BTH+":function(t,e,n){"use strict";n.d(e,"b",
function(){return a}),e.d=function(t){return o["\u0275vid"]

...

and the >>>> <<<< is the text "class" that it seems to be falling over.

If useful, Pale Moon's console also highlighted a second issue, which may be of interest:

scripts.e950719d3d6e526a0731.bundle.js:1 Line 206230

Mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with 
the correct initial [[Prototype]] value using Object.create 

and IE11 highlighted two instances of disallowed self-closing tags in an SVG:

HTML1500: Tag cannot be self-closing. Use an explicit closing tag. (Line: 1, Column: 2004)
HTML1500: Tag cannot be self-closing. Use an explicit closing tag. (Line: 1, Column: 3076)

The errors are raised by self-closing <path /> and <animate /> elements within an SVG.

<svg version="1.1" class="loading-logo" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" 
x="0px" y="0px" width="128px" height="128px" viewBox=".........">
<path d="..." />
<animate attributeName="opacity" attributeType="XML" values=".9; .4; .9" begin="-1.0s" dur="1.4s" repeatCount="indefinite"/>
</svg>

Update:

Apparently the "class" keyword isn't supported in ES5 or earlier, which includes the default browsers on any version of Windows <10 (and some other browsers). So anyone running Windows versions 7, 8 or 8.1 (which are still widely in use) won't be able to access the WebUI after update to 11.2-RELEASE, unless they install another browser or this issue is fixed.

One "quick automated solution" suggested in the comments is to add a step in the build process that transpiles the JS code to ES5 (using Babel **) before or after webpacking, to ensure the WebUI continues to run nicely on older browsers and Windows <10 with fairly minimal work, and also handle other undetected/future browser compatibility-breaking issues whether known or not. This might be a good idea as it'll help avoid "doesn't work on default browser X" issues as time goes on, and may reduce GUI testing demands.

** Babel (Github repo Website) is an open source project specifically designed for this task, i.e., converting current javascript via syntax/transform rules, to ensure the final code is also backwards compatible with older browsers and JS/ES versions.

#8 Updated by Dru Lavigne almost 3 years ago

  • Status changed from Screened to In Progress

#9 Updated by Dru Lavigne almost 3 years ago

  • Target version changed from 11.2-U2 to 11.2-U3

#11 Updated by Anonymous almost 3 years ago

Master PR is merged, just need stable now

#12 Updated by Damian Szidiropulosz almost 3 years ago

48844

#14 Updated by Dru Lavigne over 2 years ago

  • Target version changed from 11.2-U3 to 11.2-U4

#15 Avatar?id=14398&size=24x24 Updated by Kris Moore over 2 years ago

  • Status changed from In Progress to Closed

Also available in: Atom PDF